fix(auth): implement PKCE for Google Auth and sync latest upstream notifications - #4927
Open
ranjank2alpha wants to merge 18 commits into
Open
fix(auth): implement PKCE for Google Auth and sync latest upstream notifications#4927ranjank2alpha wants to merge 18 commits into
ranjank2alpha wants to merge 18 commits into
Conversation
added 17 commits
August 4, 2026 09:21
…tray support Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
…esult Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
This commit addresses the following issues: - Moved Google SSO to the primary landing screen, removing the legacy welcome screen. - Bypassed the redundant importIdentity call that caused users to loop on the login screen after OAuth success. - Cleaned up NostrKeyImportForm.tsx to strictly handle manual imports, removing the out-of-place Google Login button. - Added Tauri setup hook for set_app_user_model_id in lib.rs to allow Windows to register notifications natively. - Updated CONTEXT.md with new KIs for Google SSO and Windows Notifications. Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev>
Signed-off-by: Ranjan <ranjan@local.dev> # Conflicts: # desktop/src/features/notifications/use-feed-desktop-notifications.ts
…ions Signed-off-by: Ranjan <ranjan@local.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code_challengeandcode_verifierwith S256 method) for native Google OAuth2 login flow ingoogle_auth.rs.status().is_success()) before parsing OAuth token exchange JSON responses to prevent unwrap crashes on 4xx responses.mainupdates and resolves notification sound/active target check conflicts inuse-feed-desktop-notifications.ts.Testing