Skip to content

Crypto Wallet Core Type Checking - #4217

Draft
MicahMaphet wants to merge 6 commits into
bitpay:masterfrom
MicahMaphet:cwc-typing
Draft

Crypto Wallet Core Type Checking#4217
MicahMaphet wants to merge 6 commits into
bitpay:masterfrom
MicahMaphet:cwc-typing

Conversation

@MicahMaphet

Copy link
Copy Markdown
Contributor

Description ✏️

Add type checking to crypto-wallet-core.

Changelog 🪵

  • Export all parameter types used in TransactionProxy for the transaction providers
  • Method signature overloading for all TransactionProxy functions
  • Type checking the chain forces capitalization for chain argument

Testing Notes 🥼

npm test works


Checklist ✅

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant