Remove deprecated secp256k1_context_no_precomp pointer#1886
Open
theStack wants to merge 1 commit into
Open
Conversation
This context pointer has been deprecated since the rename to `_context_static` more than three and a half years ago (see PR bitcoin-core#1126, commit 53796d2), for the first official release 0.2.0. Removing it should be fine by now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This context pointer has been deprecated since the rename to
_context_staticmore than three and a half years ago (see PR #1126, commit 53796d2), for the first official release 0.2.0. Removing it should be fine by now.Same as for #1776, there is no urgency for this change, so it can wait until there are more reasons for a breaking release.