Fix #1191: Naming convention for secret function arguments#1875
Open
kallal79 wants to merge 1 commit into
Open
Fix #1191: Naming convention for secret function arguments#1875kallal79 wants to merge 1 commit into
kallal79 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR establishes a formal, side-channel-aware naming convention for secret function arguments. It updates CONTRIBUTING.md to require the sec prefix for any function arguments processed in constant time. Relevant secret arguments in the API (like key32, nonce32, tweak32, and aux_rand32) have been renamed to seckey32, secnonce32, sectweak32, and aux_secrand32. Arguments that are intentionally not constant-time (such as public tweaks) remain unchanged, clearly distinguishing their behavior. All underlying source files, headers, and tests have been updated and fully tested to ensure no regressions.