Skip to content

BIP459: Add FullAgg (DahLIAS) module#1754

Open
fjahr wants to merge 10 commits into
bitcoin-core:masterfrom
fjahr:dahlias
Open

BIP459: Add FullAgg (DahLIAS) module#1754
fjahr wants to merge 10 commits into
bitcoin-core:masterfrom
fjahr:dahlias

Conversation

@fjahr

@fjahr fjahr commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

This PR adds a FullAgg module implementing full aggregation of BIP 340 signatures using the interactive aggregate signature scheme (DahLIAS).

The implementation follows the BIP459.

@w0xlt

w0xlt commented May 8, 2026

Copy link
Copy Markdown
Contributor

Concept ACK

The naming of these functions suggested they should be moved to group.h
but this didn't seem practical since these functions depended on eckey.h
internally which is higher level than group.h.
@fjahr fjahr changed the title Add FullAgg module Add FullAgg (DahLIAS) module Jul 10, 2026
@fjahr
fjahr force-pushed the dahlias branch 2 times, most recently from 4e8695a to ab6fdeb Compare July 11, 2026 11:00
@fjahr

fjahr commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

The last commit here now is implementing the code sharing between the musig and the fullagg model. That is one of the first questions I have when reviewers will take a closer look here: Do we want to do it this way? And do we event want to do this at all? I think it's pretty good but also the amount of LOC saving has been a bit underwhelming at the end.

A second thing that I changed and that I would be interested in high-level feedback on: I realized that the fullagg module really doesn't need any of the Schnorr module code, it just depends on extrakeys. I fixed this in the config where I still had the schnorr module as dependency of the fullagg module. However, in practical terms they will likely always be active together and it's also a bit awkward that I still have the module named schnorrsig_fullagg which I took over from the Halfagg PR where it's schnorrsig_halfagg. The most correct way would be to remove the schnorrsig part here but I am also unsatisfied with the asymmetry this would create 🙈 If anyone has opinions on this I am happy to hear them.

@fjahr
fjahr marked this pull request as ready for review July 11, 2026 12:30
@fjahr fjahr changed the title Add FullAgg (DahLIAS) module BIP459: Add FullAgg (DahLIAS) module Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants