Warn when append-on-drop guards are unused - #375
Open
danielgaskins wants to merge 1 commit into
Open
Conversation
rcoh
reviewed
Aug 25, 2026
Signed-off-by: Daniel Gaskins <danielgaskins99@gmail.com>
danielgaskins
force-pushed
the
fix/append-on-drop-must-use
branch
from
August 26, 2026 17:09
8f86357 to
26e8baf
Compare
Contributor
Author
|
Hi @rcoh, could you take another look when you have a chance? The updated diagnostic now covers both options you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppendAndCloseOnDropasmust_useso unused guards produce a warningdropFixes #364
Testing
cargo +1.91 nextest runcargo +1.91.0 test -p metrique --test uicargo +1.91 clippy --workspace --all-features -- -D warningscargo +nightly fmt --all -- --check