feat(metrique-util): prototype request-scoped metrics pools - #358
Draft
rcoh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricsPooland cloneableMetricsPoolHandlefor heterogeneous child metrics flattened into a parent entryStack
This draft implementation is stacked on RFC PR #357. Its diff contains only the prototype; retarget it to
mainafter #357 merges.Testing
cargo +nightly fmt --allcargo clippy --workspace --all-features -- -D warningscargo +1.91 nextest run -p metrique-util --test metrics_pool(7 passed)cargo +1.91 test -p metrique-util --example sdk-interceptor-metrics-pool --features metrics-pool(3 passed)CARGO_INCREMENTAL=0 cargo +1.91 nextest run(697 passed)cargo bench -p metrique-util --bench metrics_pool --features metrics-pool