fix: run tenant migrations from mix ash.setup - #836
Merged
zachdaniel merged 1 commit intoAug 21, 2026
Conversation
Fixes ash-project#807. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #807.
Contributor checklist
Leave anything that you believe does not apply unchecked.
mix ash.setupwas supposed to run tenant migrations after public ones, but it never did.Three bugs:
has_tenant_migrations?/1returned true when there were no tenant filesash_postgres.migratecall was skipped because Mix won't run the same task twice (runvsrerun)--tenantinstead of--tenantsThis inverts the check, uses
Mix.Task.rerun/2with--tenants, does the same for thetest.resetalias, and adds regression tests.