chore(ci): run cargo test, fmt and clippy for rustler projects - #2825
Merged
Conversation
The reusable workflow compiles the NIF but never runs the crate's own Rust checks, so `cargo test`, `cargo fmt` and `cargo clippy` results never appear in CI. A project can have a fully green pipeline with failing Rust tests. Adds a `rust-check` job that runs all three whenever `rustler-precompiled-module` is set, and adds it to the `needs` of `build-release` and `hex_publish` so a failing Rust check blocks a release. Crate directories are discovered from the repository's `Cargo.toml` files so no per-project configuration is required. The optional `rust-crate-dir` input overrides discovery when a repository wants a single crate checked.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable workflow compiles the NIF as part of
mix test, but it never runsthe crate's own Rust checks —
cargo test,cargo fmtandcargo clippyFor: ash-project/igniter_js#68