chore: bump gitops-engine w/ finalizer fix#24348
Merged
agaudreault merged 3 commits intoSep 3, 2025
Merged
Conversation
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Contributor
|
I just hit the same UT failure in CI. to save you some time, I think this might be the fix Not sure why it succeeded on prior runs. |
Member
|
Opened a PR with the fix: #24349 |
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
crenshaw-dev
approved these changes
Sep 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24348 +/- ##
==========================================
+ Coverage 60.18% 60.21% +0.03%
==========================================
Files 348 348
Lines 59918 59918
==========================================
+ Hits 36064 36082 +18
+ Misses 20959 20944 -15
+ Partials 2895 2892 -3 ☔ View full report in Codecov by Sentry. |
|
@crenshaw-dev Will it be cherrypicked for release 3.0 soon ? Thanks |
Mangaal
pushed a commit
to Mangaal/argo-cd
that referenced
this pull request
Sep 10, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
akhilsingh-git
pushed a commit
to akhilsingh-git/argo-cd
that referenced
this pull request
Sep 11, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Akhil Singh <singhakhil69@gmail.com>
downfa11
pushed a commit
to downfa11/argo-cd
that referenced
this pull request
Sep 12, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
sivasath16
pushed a commit
to sivasath16/argo-cd
that referenced
this pull request
Sep 17, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
sivasath16
pushed a commit
to sivasath16/argo-cd
that referenced
this pull request
Sep 17, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploys argoproj/gitops-engine#770