fix(sync): support Ref-typed properties in live two-way sync - #27
Open
0hirume wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to argon-rbx/argon#282, which addresses argon-rbx/argon#269 (
Ref-typed property sync, e.g.Model.PrimaryPart,Weld.Part0/Part1,ObjectValue.Value).RefandSharedStringcodecs inEncodedValue(previously stubs that errored), threading atreereference throughencode/decodesoRefvalues can be resolved to/from instances viaTree:getId/Tree:getInstance.Dom.getRefProperties(className)to discoverRef-typed properties via the API database, since they have noDefaultPropertiesentry and were previously never read.Read/Writeprocessors now read and applyRef-typed properties during live sync.stylua --check/seleneon changed filesargonbranch: PrimaryPart and Weld Part0/Part1 sync correctly in both directions without crashing