Skip to content

[Arith] Fix dom_map var leak in IntervalSet relaxation#19962

Closed
guan404ming wants to merge 1 commit into
apache:mainfrom
guan404ming:fix-intset-relax-var-leak
Closed

[Arith] Fix dom_map var leak in IntervalSet relaxation#19962
guan404ming wants to merge 1 commit into
apache:mainfrom
guan404ming:fix-intset-relax-var-leak

Conversation

@guan404ming

@guan404ming guan404ming commented Jul 6, 2026

Copy link
Copy Markdown
Member

Why

#19927 made IntervalSetEvaluator::Eval(IntervalSet) keep the original parametric bound when relaxation loses it to infinity, even if that bound references a var being relaxed out. The leaked var reached allocation extents outside its scope, so compiling cumsum for CUDA crashed with variable i has been used before definition in CI.

How

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prevents variables being relaxed out from leaking outside their scope by ensuring that preserved parametric bounds do not reference them. A helper lambda f_depends_on_relaxed is introduced in IntervalSetEvaluator to check for these dependencies, and a corresponding unit test has been added to verify this behavior. There are no review comments, so no additional feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@guan404ming guan404ming force-pushed the fix-intset-relax-var-leak branch from 5ca0495 to f252030 Compare July 6, 2026 17:31
@tqchen

tqchen commented Jul 6, 2026

Copy link
Copy Markdown
Member

i think we are moving towards a directly that over complicates things here i will do a separate followup

@tqchen

tqchen commented Jul 6, 2026

Copy link
Copy Markdown
Member

#19963

@tqchen tqchen closed this Jul 6, 2026
@guan404ming

Copy link
Copy Markdown
Member Author

Make sense, thanks @tqchen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants