Rename evaluationTimeout to timeoutMs#3508
Merged
Merged
Conversation
spmallette
reviewed
Jul 7, 2026
spmallette
reviewed
Jul 7, 2026
spmallette
reviewed
Jul 7, 2026
spmallette
reviewed
Jul 7, 2026
spmallette
reviewed
Jul 7, 2026
spmallette
reviewed
Jul 7, 2026
spmallette
reviewed
Jul 7, 2026
Collapses the per-request execution timeout onto a single name, `timeoutMs`, across the server config, the script `with()` token, the internal executor, error messages, and all five GLV APIs. The legacy `evaluationTimeout` and `scriptEvaluationTimeout` names are removed with no alias. The point of the change was to eliminate a dual-name inconsistency, so it made little sense to stop halfway. The 4.x wire protocol already used `timeoutMs` while the config key, script token, and three drivers still spoke `evaluationTimeout` — the server even resolved the effective timeout by checking both names. Renaming only some surfaces would relocate that confusion rather than remove it, and leaving the driver builder methods on the old name would trade a wire-vs-config mismatch for a wire-vs-API one. Assisted-by: Claude Code:claude-opus-4-8
Makes these time-based options consistent with GLVs that already use the "Millis" suffix rather than no suffix or "Ms". This also renames timeoutMs to timeoutMillis in the HTTP API as well to make that consistent as well. Assisted-by: Claude Code:claude-opus-4-8
kenhuuu
force-pushed
the
rename-evalTimeout
branch
from
96ba2de to
85cb2ad
Compare
Contributor
Author
|
Addressed all feedback and lazy consensus reached so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapses the per-request execution timeout onto a single name,
timeoutMs, across the server config, the scriptwith()token, the internal executor, error messages, and all five GLV APIs. The legacyevaluationTimeoutandscriptEvaluationTimeoutnames are removed with no alias.The point of the change was to eliminate a dual-name inconsistency, so it made little sense to stop halfway. The 4.x wire protocol already used
timeoutMswhile the config key, script token, and three drivers still spokeevaluationTimeout— the server even resolved the effective timeout by checking both names. Renaming only some surfaces would relocate that confusion rather than remove it, and leaving the driver builder methods on the old name would trade a wire-vs-config mismatch for a wire-vs-API one.Review guide:
This is another PR that is mostly a search and replace of
evaluationTimeouttotimeoutMs. What's important for other reviewers to decide is whether this change should have applied as widely as it did. This effectively changes it everywhere including in the server where the YAML will just readtimeoutMs.evaluationTimeoutis arguably a more descriptive name, but an effort was made to try and explain what timeoutMs is everywhere that it is used.VOTE +1