[ISSUE #10589] Rename DecodeMessageIdCommond to DecodeMessageIdCommand

[yx9o]

• Fixes [Enhancement] Rename misspelled DecodeMessageIdCommond class #10589.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.16%. Comparing base (8242c1e) to head (4fe02bc).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../tools/command/message/DecodeMessageIdCommand.java	0.00%	6 Missing ⚠️
.../apache/rocketmq/tools/command/MQAdminStartup.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10590      +/-   ##
=============================================
- Coverage      48.26%   48.16%   -0.10%     
+ Complexity     13433    13406      -27     
=============================================
  Files           1378     1378              
  Lines         100817   100817              
  Branches       13040    13041       +1     
=============================================
- Hits           48660    48563      -97     
- Misses         46211    46290      +79     
- Partials        5946     5964      +18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[RongtongJin]

I left one inline comment about the unused command.

[RongtongJin]

This command does not seem to be registered or referenced anywhere. Would it be better to remove it instead of renaming it?

[yx9o]

Good point. Since this command has a clear purpose but is currently not registered, I prefer keeping it and registering it in MQAdminStartup instead of removing it.

[RockteMQ-AI]

Review by github-manager-bot

Summary

Fixes a typo in the class name (DecodeMessageIdCommond → DecodeMessageIdCommand), registers the command in MQAdminStartup, and makes the -i option required (since decoding without a message ID is meaningless).

Findings

• [Info] MQAdminStartup.java:265 — The old class DecodeMessageIdCommond was never registered in initCommand(), so this effectively adds a new usable command rather than renaming an existing one. No backward-compatibility concern.

• [Info] DecodeMessageIdCommand.java:30 — Changing commandName() from "DecodeMessageId" to "decodeMessageId" follows the camelCase convention used by other subcommands. Good.

• [Info] DecodeMessageIdCommand.java:41 — Making -i required (setRequired(true)) is correct — the command cannot function without a message ID.

Verdict

Clean, small fix. Typo correction + proper command registration. LGTM.

---

Automated review by github-manager-bot

[RockteMQ-AI]

Review by github-manager-bot (re-review)

Update since last review

New commit 4fe02bc (2026-07-08) addresses @RongtongJin's feedback by registering DecodeMessageIdCommand in MQAdminStartup.initCommand(). The command is now properly wired into the CLI tool.

Changes in this commit

1. MQAdminStartup.java: Added import and initCommand(new DecodeMessageIdCommand()) — resolves the "unused command" concern
2. commandName(): Changed from "DecodeMessageId" to "decodeMessageId" — follows camelCase convention consistent with other subcommands
3. commandDesc(): Capitalized first letter, added period — minor style improvement
4. -i option: Changed from setRequired(false) to setRequired(true) — prevents NPE when no message ID is provided
5. Output format: Changed from ip=%s / date=%s to IP: %s%n / Date: %s%n — more readable with proper newlines
6. Error handling: Consolidated two separate try-catch blocks into one, replaced silent e.printStackTrace() with SubCommandException — proper error propagation

Findings

• [Warning] DecodeMessageIdCommand.java:31 — commandName() changed from "DecodeMessageId" to "decodeMessageId". This is a breaking change for users who have scripts or automation relying on the old command name (e.g., mqadmin DecodeMessageId -i xxx). Consider keeping backward compatibility by supporting both names, or at minimum document this in the PR description / release notes.

• [Info] DecodeMessageIdCommand.java:37 — Making -i required is the right call. The old code would NPE on commandLine.getOptionValue('i').trim() if the option was omitted. Good fix.

• [Info] DecodeMessageIdCommand.java:50-53 — Output format change (IP: ... / Date: ...) is more readable. Note that scripts parsing the old ip=.../date=... format will need updating.

Verdict

The new commit properly addresses the reviewer feedback. The code changes are clean and improve error handling. The main concern is the CLI command name change — flagging it as a potential compatibility issue for downstream users.

---

Automated review by github-manager-bot