Bound Artery stream shutdown#3317
Open
He-Pin wants to merge 1 commit into
Open
Conversation
Motivation: Artery waited without a deadline for remoting stream completion during termination, so a stalled stream could block transport shutdown indefinitely. Modification: Add a configurable stream shutdown timeout, continue with transport cleanup when it expires or the scheduler is unavailable, document the setting, and add directional regression coverage. Result: Stalled remoting streams no longer prevent Artery transport shutdown, while the normal streams-before-transport ordering remains unchanged. Tests: - Aeron ArteryTransportShutdownSpec and FlushOnShutdownSpec: 3 tests passed - sbt +mimaReportBinaryIssues: passed - sbt +headerCheckAll: passed - sbt docs/paradox: passed - sbt checkCodeStyle: passed - sbt sortImports: not completed due installed Scalafix/Scalameta binary incompatibility - sbt validatePullRequest: not run per request References: Fixes apache#3247
He-Pin
force-pushed
the
fix/3247-bound-artery-shutdown
branch
from
1d440ba to
263965a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Artery waits without a deadline for remoting stream completion during ActorSystem termination. A stalled stream can therefore prevent transport-specific shutdown from starting and keep the actor system alive indefinitely.
Modification
pekko.remote.artery.advanced.shutdown-streams-timeoutwith a 10-second default.Result
A stalled remoting stream no longer blocks Artery transport shutdown indefinitely.
References
Fixes #3247