HDDS-15648. Improve TestSnapshotDiffManager#testThreadPoolIsFull drain scenario#10632
Open
cchung100m wants to merge 2 commits into
Open
HDDS-15648. Improve TestSnapshotDiffManager#testThreadPoolIsFull drain scenario#10632cchung100m wants to merge 2 commits into
cchung100m wants to merge 2 commits into
Conversation
…n scenario by filling the pool before releasing workers
chungen0126
reviewed
Jun 30, 2026
Comment on lines
+1215
to
+1219
| if (drainBetweenBatches && latchOpened) { | ||
| while (totalSubmitted - completedJobs.get() >= fullThreadPoolSize) { | ||
| Thread.sleep(10); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Thanks @cchung100m for working on this. We should avoid using a while loop with Thread.sleep for busy-waiting here. Let's refactor this using JavaUtils#attempt to make the waiting logic cleaner and safer.
Contributor
Author
There was a problem hiding this comment.
Hi @chungen0126
Thanks for review comments. I have updated the part you mentioned.
cchung100m
force-pushed
the
hdds-15648
branch
7 times, most recently
from
c1ac22a to
c210dc6
Compare
adoroszlai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve TestSnapshotDiffManager#testThreadPoolIsFull drai n scenario by filling the pool before releasing workers
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15648
How was this patch tested?
Existing unit and integration tests