MINIFICPP-2871 Create conanfile for openssl-fips target - #2223
Open
lordgamez wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds a Conan “openssl-fips” (FIPS provider module) third-party package and wires it into the Conan + CMake OpenSSL flow to ship the FIPS module in produced artifacts.
Changes:
- Introduces a new
thirdparty/openssl-fipsConan package (config, sources, recipe) for OpenSSL 3.1.2 FIPS provider builds - Adds
openssl-fipsas a Conan requirement - Updates CMake OpenSSL acquisition to locate and install the FIPS provider module from Conan packages
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| thirdparty/openssl-fips/config.yml | Adds third-party package version mapping for openssl-fips |
| thirdparty/openssl-fips/all/conanfile.py | New Conan recipe to build/install the OpenSSL FIPS provider module |
| thirdparty/openssl-fips/all/conandata.yml | Defines OpenSSL 3.1.2 source tarball + checksum for the FIPS build |
| conanfile.py | Adds openssl-fips/3.1.2@minifi/develop to the project requirements |
| cmake/GetOpenSSL.cmake | Switches to find_package(openssl-fips) and installs the FIPS module + openssl binary into packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+34
| package_type = "shared-library" | ||
| settings = "os", "arch", "compiler", "build_type" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2871
Depends on #2218
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.