MINIFICPP-2861 Add Conan support for docker and clang CI builds - #2216
Open
lordgamez wants to merge 1 commit into
Open
MINIFICPP-2861 Add Conan support for docker and clang CI builds#2216lordgamez wants to merge 1 commit into
lordgamez wants to merge 1 commit into
Conversation
lordgamez
marked this pull request as ready for review
July 24, 2026 12:32
8 tasks
lordgamez
force-pushed
the
MINIFICPP-2861
branch
from
July 27, 2026 07:50
85e8f74 to
87b4824
Compare
fgerlits
approved these changes
Jul 27, 2026
lordgamez
force-pushed
the
MINIFICPP-2860
branch
from
July 29, 2026 08:22
538e062 to
17c0339
Compare
lordgamez
force-pushed
the
MINIFICPP-2861
branch
from
July 29, 2026 08:35
87b4824 to
4ba9738
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds Conan-based dependency handling for Docker builds and the Ubuntu clang CI job, including a custom Conan recipe for paho-mqtt-c and wiring credentials/flags through CMake → DockerBuild.sh → Dockerfiles.
Changes:
- Introduce a custom Conan recipe + metadata for
paho-mqtt-cand switch MiNiFi’s Conan dependency to@minifi/develop - Add Docker build support for running
bootstrap/main.py --run-conan-installand using Conan toolchains - Update CI to enable Conan for clang builds and upload Conan packages
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| thirdparty/paho-mqtt/config.yml | Adds third-party Conan recipe version mapping for paho-mqtt |
| thirdparty/paho-mqtt/all/conanfile.py | Introduces custom Conan recipe for paho-mqtt-c |
| thirdparty/paho-mqtt/all/conandata.yml | Adds source + patch metadata for the recipe |
| docker/settings_user.yml | Adds Conan settings_user.yml override for Linux libc (musl) |
| docker/rockylinux/Dockerfile | Adds Conan bootstrap/install path and optional upload in Rocky build |
| docker/Dockerfile | Adds Conan bootstrap/install path and optional upload in Alpine build |
| docker/DockerBuild.sh | Adds build args/secrets for Conan and wires them into docker buildx |
| conanfile.py | Switches paho-mqtt-c ref to custom remote and tweaks toolchain blocks |
| cmake/PahoMqttC.cmake | Adjusts patch path for paho-mqtt-c build |
| cmake/MiNiFiOptions.cmake | Adds docker Conan options and filters them from MINIFI_OPTIONS passed into images |
| cmake/DockerConfig.cmake | Passes Docker Conan options into DockerBuild.sh invocation |
| bootstrap/package_manager.py | Adds APK package manager support for Alpine |
| bootstrap/minifi_option.py | Adds DOCKER_USE_CONAN to bootstrap option handling |
| bootstrap/main.py | Adds --run-conan-install entrypoint |
| bootstrap/cli.py | Improves Conan settings detection (libc++) and forces m4 build on Linux |
| .github/workflows/ci.yml | Enables Conan in CI (Docker + clang job) and uploads Conan packages |
| .dockerignore | Ensures docker/settings_user.yml is included in Docker build context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2861
Depends on #2214
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.