Improve XMLUtil and usage#9488
Draft
mbien wants to merge 2 commits into
Draft
Conversation
The parse methods will leave it at its default value since setting it to true by default would break compatibility. 'getDOMImplementation()' and 'normalize()' will now set it to true. note: It is a 3-state boolean with JDK (11+) default set to true. Setting it to true again however, enables additional checks since the JDK impl tracks if it has been set explicitly by the application. That is also why passing false as parameter to the new methods will leave it at its default value instead of turning it completely off.
some dead code removal
mbien
added
ci:all-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.