KNOX-3375: Wire in gatewayservices for LDAPRolesLookupInterceptorFact…#1303
Merged
Conversation
…ory so KnoxCLI is able to load it
Test Results36 tests 36 ✅ 4s ⏱️ Results for commit c6a801e. |
smolnar82
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ory so KnoxCLI is able to load it
KNOX-3375 - KnoxCLI fails if rolesLookupInterceptor is enabled
What changes were proposed in this pull request?
GatewayServicesinstance fromLdapServiceFactorythroughKnoxLDAPService→KnoxLDAPServerManager→InterceptorFactory→LDAPRolesLookupInterceptorFactory, so the factory no longer depends on the null-under-knoxcli staticGatewayServer.getGatewayServices(). This lets knoxcli commands succeed when rolesLookup is configured, sinceCLIGatewayServicesalready registersLDAP_ROLES_LOOKUP_SERVICE.How was this patch tested?
Enabled rolesLookupInterceptor and tested knoxcli, unit tests
Integration Tests
N/A
UI changes
N/A