fix: port security improvement (XSS) from Felix WebConsole#2729
Open
jbonofre wants to merge 1 commit into
Open
fix: port security improvement (XSS) from Felix WebConsole#2729jbonofre wants to merge 1 commit into
jbonofre wants to merge 1 commit into
Conversation
holgerfriedrich
approved these changes
Jul 7, 2026
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.felix.webconsole.internal.core; |
Contributor
There was a problem hiding this comment.
maybe add some comment here that this is the original file form
https://github.com/apache/felix-dev/blob/org.apache.felix.webconsole-4.8.12/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/ServicesServlet.java
plus the replacement escapeJavaScript()
| } | ||
|
|
||
|
|
||
| private static String escapeJavaScript( final String input ) |
Contributor
There was a problem hiding this comment.
Contributor
|
Good to have a workaround. This webconsole warning was long time around and we simply could not upgrade due to jakarta switch. I'd just recommend the two references above to be added, otherwise LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #2719