docs: improve ancestors_between docs to make behaviour more clear#2796
Open
xanderbailey wants to merge 1 commit into
Open
docs: improve ancestors_between docs to make behaviour more clear#2796xanderbailey wants to merge 1 commit into
xanderbailey wants to merge 1 commit into
Conversation
Contributor
Author
|
@CTTY are you able to take a look here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Test here
iceberg-rust/crates/iceberg/src/util/snapshot.rs
Lines 173 to 180 in 3253d1c
oldest_snapshot_idis not an ancestor oflatest_snapshot_idthen the whole chain is returned but this isn't clear to the caller without reading the implementation or the tests.What changes are included in this PR?
Docs changes
Are these changes tested?