chore(commons): remove redundant version property#3089
Conversation
vaijosh
left a comment
There was a problem hiding this comment.
Good observation @hingu-8103 . Thanks.
LGTM.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #3089 +/- ##
============================================
- Coverage 37.96% 31.69% -6.28%
+ Complexity 519 498 -21
============================================
Files 805 816 +11
Lines 68404 69555 +1151
Branches 8993 9190 +197
============================================
- Hits 25968 22043 -3925
- Misses 39697 45110 +5413
+ Partials 2739 2402 -337 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Blocking: yes. Summary:
- The POM version replacement itself looks consistent, but one release/versioning instruction still references the removed hugegraph-commons.version property, and the PR has a visible codecov/project failure.
- Evidence: hugegraph-commons/hugegraph-common/src/main/resources/version.properties still says hugegraph-commons.version in the pom file needs to be updated;
- mvn -q -pl hugegraph-server,hugegraph-pd/hg-pd-service,hugegraph-store/hg-store-rocksdb -am validate -DskipTests passed locally; codecov/project is failing on the latest head.
|
Hi @imbajin, |
VGalaxies
left a comment
There was a problem hiding this comment.
No actionable findings.
Verified git diff --check, repository-wide references, Maven effective-model resolution with -Drevision=9.9.9-review, and a clean git merge-tree.
Purpose of the PR
The
hugegraph-commonsmodule is already versioned by${revision}.At the same time, the root POM defines a separate property
hugegraph-commons.versionthat tracks the same value.This creates a duplicated version source for the same module family.
Main Changes
hugegraph-commons.versionfrom rootpom.xml${hugegraph-commons.version}with${project.version}in:hugegraph-server/pom.xmlhugegraph-store/hg-store-rocksdb/pom.xmlhugegraph-pd/hg-pd-service/pom.xmlVerifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need