Skip to content

Address review feedback on databinding whitelist characterization spec #16054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borinquenkid merged 1 commit into from
Jul 26, 2026
Merged

Address review feedback on databinding whitelist characterization spec #16054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions ...web/src/test/groovy/org/grails/web/binding/DefaultDatabindingWhitelistBehaviorSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,15 @@ import spock.lang.Specification

class DefaultDatabindingWhitelistBehaviorSpec extends Specification implements ControllerUnitTest<WhitelistBehaviorController> {

void 'domain binding includes simple and association properties but excludes special and unlisted properties'() {
// Domain exclusion of id/version/dateCreated/lastUpdated is already pinned by
// DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec (GRAILS-11173, #15681); this spec
// only covers the Object/def-typed exclusion and nested association binding.
void 'domain binding includes simple and association properties but excludes Object/def-typed properties'() {
given:
Date dateCreated = new Date()
Date lastUpdated = new Date()
Map source = [
name: 'Ada',
address: [street: 'Analytical Engine Way'],
id: 99L,
version: 7L,
dateCreated: dateCreated,
lastUpdated: lastUpdated,
ignored: 'not bindable'
untypedProperty: 'not bindable'
]

when:
Expand All @@ -48,14 +45,10 @@ class DefaultDatabindingWhitelistBehaviorSpec extends Specification implements C
then:
domain.name == 'Ada'
domain.address.street == 'Analytical Engine Way'
domain.id == null
domain.version == null
domain.dateCreated == null
domain.lastUpdated == null
domain.ignored == null
domain.untypedProperty == null
}

void 'Validateable command binding includes declared special properties but excludes unlisted properties'() {
void 'Validateable command binding includes declared special properties but excludes Object/def-typed properties'() {
given:
Date dateCreated = new Date()
Date lastUpdated = new Date()
Expand All @@ -65,7 +58,7 @@ class DefaultDatabindingWhitelistBehaviorSpec extends Specification implements C
params.version = '7'
params.dateCreated = dateCreated
params.lastUpdated = lastUpdated
params.ignored = 'not bindable'
params.untypedProperty = 'not bindable'

when:
WhitelistCommand command = controller.bindCommand().command
Expand All @@ -77,21 +70,15 @@ class DefaultDatabindingWhitelistBehaviorSpec extends Specification implements C
command.version == 7L
command.dateCreated == dateCreated
command.lastUpdated == lastUpdated
command.ignored == null
command.untypedProperty == null
}
}

@Entity
class WhitelistDomain {
String name
WhitelistAddress address = new WhitelistAddress()
Long id
Long version
Date dateCreated
Date lastUpdated
Object ignored

static hasOne = [address: WhitelistAddress]
Object untypedProperty
}

@Entity
Expand All @@ -113,5 +100,5 @@ class WhitelistCommand implements Validateable {
Long version
Date dateCreated
Date lastUpdated
Object ignored
Object untypedProperty
}
Loading