[FLINK-40039] Fix CTAS/RTAS when used with set-semantic PTFs #28595
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.runtime.stream.sql; | ||
|
|
||
| import org.apache.flink.table.catalog.ResolvedSchema; | ||
| import org.apache.flink.table.functions.ProcessTableFunction; | ||
| import org.apache.flink.table.planner.factories.TestValuesTableFactory; | ||
| import org.apache.flink.table.planner.plan.nodes.exec.stream.ProcessTableFunctionTestUtils.SetSemanticTableFunction; | ||
| import org.apache.flink.table.planner.runtime.utils.StreamingTestBase; | ||
| import org.apache.flink.table.planner.runtime.utils.TestData; | ||
|
|
||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** IT Case for CREATE TABLE AS SELECT statement over a {@link ProcessTableFunction}. */ | ||
| class CTASITCase extends StreamingTestBase { | ||
|
|
||
| @BeforeEach | ||
| @Override | ||
| public void before() throws Exception { | ||
| super.before(); | ||
| final String dataId = TestValuesTableFactory.registerData(TestData.smallData3()); | ||
| tEnv().executeSql( | ||
| String.format( | ||
| "CREATE TABLE source(a int, b bigint, c string)" | ||
| + " WITH ('connector' = 'values', 'bounded' = 'true', 'data-id' = '%s')", | ||
| dataId)); | ||
| tEnv().createTemporarySystemFunction("f", SetSemanticTableFunction.class); | ||
| } | ||
|
|
||
| @Test | ||
| void testCreateTableAsSelectOverSetSemanticPtfWithReorderedColumns() throws Exception { | ||
| tEnv().executeSql( | ||
| "CREATE TABLE sink (`out`, `a`) WITH ('connector' = 'values') AS " | ||
| + "SELECT * FROM f(r => TABLE source PARTITION BY a, i => 1)") | ||
| .await(); | ||
|
|
||
| final ResolvedSchema schema = tEnv().from("sink").getResolvedSchema(); | ||
| assertThat(schema.getColumnNames()).containsExactly("out", "a"); | ||
|
|
||
| assertThat(TestValuesTableFactory.getResultsAsStrings("sink")) | ||
| .containsExactlyInAnyOrder( | ||
| "+I[{+I[1, 1, Hi], 1}, 1]", | ||
| "+I[{+I[2, 2, Hello], 1}, 2]", | ||
| "+I[{+I[3, 2, Hello world], 1}, 3]"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| == Abstract Syntax Tree == | ||
| LogicalSink(table=[default_catalog.default_database.MyCtasTable], fields=[votes, a, b, metadata_col]) | ||
|
Contributor
There was a problem hiding this comment. Isn't this a breaking change? The EXPR$0 to votes makes sense, but the additional metadata_col?
Contributor
Author
There was a problem hiding this comment. Not a breaking change. |
||
| +- LogicalProject(votes=[null:INTEGER], a=[$0], b=[$1], metadata_col=[null:BIGINT]) | ||
| +- LogicalTableScan(table=[[default_catalog, default_database, MyTable]]) | ||
|
|
||
| == Optimized Physical Plan == | ||
| Sink(table=[default_catalog.default_database.MyCtasTable], fields=[votes, a, b, metadata_col]) | ||
| +- Calc(select=[null:INTEGER AS votes, a, b, null:BIGINT AS metadata_col]) | ||
| +- DataStreamScan(table=[[default_catalog, default_database, MyTable]], fields=[a, b, c]) | ||
|
|
||
| == Optimized Execution Plan == | ||
| Sink(table=[default_catalog.default_database.MyCtasTable], fields=[votes, a, b, metadata_col]) | ||
| +- Calc(select=[null:INTEGER AS votes, a, b, null:BIGINT AS metadata_col]) | ||
| +- DataStreamScan(table=[[default_catalog, default_database, MyTable]], fields=[a, b, c]) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.