Skip to content

[Fix-18391] [Alert] Remove redundant plugin definition table existence check during AlertServer startup #18392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njnu-seafish wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

[Fix-18391] [Alert] Remove redundant plugin definition table existence check during AlertServer startup #18392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88a5180
fix: use lowercase table name in information_schema query for Postgre…
Jul 2, 2026
f8a3f25
Use database-specific SQL for plugin table check
Jul 6, 2026
31309e9
Remove unnecessary plugin define table existence check
Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ...ert-server/src/main/java/org/apache/dolphinscheduler/alert/plugin/AlertPluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public AlertPluginManager(PluginDao pluginDao) {

public void start() {
log.info("AlertPluginManager start...");
checkAlertPluginExist();
installAlertPlugin();
log.info("AlertPluginManager started...");
}
Expand All @@ -64,13 +63,6 @@ public Optional<AlertChannel> getAlertChannel(int id) {
return Optional.ofNullable(alertPluginMap.get(id));
}

private void checkAlertPluginExist() {
if (!pluginDao.checkPluginDefineTableExist()) {
log.error("Plugin Define Table t_ds_plugin_define Not Exist. Please Create it First!");
System.exit(1);
}
}

private void installAlertPlugin() {
final PluginParams warningTypeParams = getWarningTypeParams();

Expand Down
9 changes: 0 additions & 9 deletions dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/PluginDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,6 @@ public class PluginDao {
@Autowired
private PluginDefineMapper pluginDefineMapper;

/**
* check plugin define table exist
*
* @return boolean
*/
public boolean checkPluginDefineTableExist() {
return pluginDefineMapper.checkTableExist() > 0;
}

/**
* add or update plugin define
*
Expand Down
7 changes: 0 additions & 7 deletions ...cheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/PluginDefineMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@

public interface PluginDefineMapper extends BaseMapper<PluginDefine> {

/**
* check table exist
*
* @return boolean
*/
int checkTableExist();

/**
* query all plugin define
*
Expand Down
3 changes: 0 additions & 3 deletions ...uler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/PluginDefineMapper.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@

<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd" >
<mapper namespace="org.apache.dolphinscheduler.dao.mapper.PluginDefineMapper">
<select id="checkTableExist" resultType="int">
select count(*) from information_schema.TABLES where table_name = 't_ds_plugin_define'
</select>

<select id="queryAllPluginDefineList" resultType="org.apache.dolphinscheduler.dao.entity.PluginDefine">
select *
Expand Down
Loading