test: cover float IN list predicates#23373
Merged
Merged
Conversation
github-actions
Bot
added
physical-expr
alamb
force-pushed
the
codex/in-list-float-slt-coverage
branch
from
5484864 to
71a7ca7
Compare
alamb
force-pushed
the
codex/in-list-float-slt-coverage
branch
from
71a7ca7 to
d632a0c
Compare
alamb
force-pushed
the
codex/in-list-float-slt-coverage
branch
from
d632a0c to
7b549f5
Compare
timsaucer
approved these changes
Jul 7, 2026
Contributor
Author
|
Thanks @timsaucer -- since this is a test only I'll just merge it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As @geoffreyclaude adds additional special implementations for IN lists we should keep up with slt test coverage. Recently we added coverage for floats
What changes are included in this PR?
This adds sqllogictest coverage for Float16, Float32, and Float64
INlist predicates inin_list.slt, mirroring the existing integerINlist coverage shape:Are these changes tested?
Yes -- all tests
Are there any user-facing changes?
No. This only adds test coverage.