CASSSIDECAR-465: Improve HTTP 429 handling across sidecar server and … - #374
Open
arjunashok wants to merge 3 commits into
Open
CASSSIDECAR-465: Improve HTTP 429 handling across sidecar server and …#374arjunashok wants to merge 3 commits into
arjunashok wants to merge 3 commits into
Conversation
arjunashok
force-pushed
the
CASSSIDECAR-465-429-retry-handling
branch
from
August 10, 2026 20:58
c50d0de to
99369f7
Compare
arjunashok
marked this pull request as ready for review
August 10, 2026 20:59
yifan-c
approved these changes
Aug 10, 2026
yifan-c
left a comment
yifan-c
left a comment
Contributor
There was a problem hiding this comment.
The fixes look good to me
Comment on lines
-375
to
+378
| runnable.run(); | ||
| else | ||
| { | ||
| runnable.run(); | ||
| } |
Contributor
There was a problem hiding this comment.
wow. This is another bug that is more serious than 429 handling in client.
| @@ -1,5 +1,6 @@ | |||
| 0.5.0 | |||
| ----- | |||
| * Improve HTTP 429 handling across sidecar server and client (CASSSIDECAR-465) | |||
Contributor
There was a problem hiding this comment.
The patch include 2 fixes. I am fine with it. Just need to reflect it correctly in the change log.
Suggested change
| * Improve HTTP 429 handling across sidecar server and client (CASSSIDECAR-465) | |
| * Support retrying on HTTP 429 responses and fix duplicate immediate execution in RequestExecutor retry scheduling (CASSSIDECAR-465) |
…client Patch by Arjun Ashok for CASSSIDECAR-465
Patch by Arjun Ashok for CASSSIDECAR-465
arjunashok
force-pushed
the
CASSSIDECAR-465-429-retry-handling
branch
from
August 12, 2026 17:49
99369f7 to
780a0de
Compare
jyothsnakonisa
self-requested a review
August 12, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…client
Changes
BasicRetryPolicyhad no case for it. As a result, clients failed after one attempt instead of backing off.BasicRetryPolicy(honorsRetry-After, falls back to configured backoff); fixes a prerequisite bug inRequestExecutor.schedule()that fired retries immediately instead of waiting (this was silently breaking the existing 503 backoff too, independent of 429); adds aRetry-Afterheader to the server's 429 response, via config:retry_after_seconds.retryAfterSeconds()is adefaultinterface method for backward compatibility