Skip to content

CAMEL-23903: Fix flaky test RouteIdTransactedIT in camel-jms #24420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnodet wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

CAMEL-23903: Fix flaky test RouteIdTransactedIT in camel-jms #24420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...c/test/java/org/apache/camel/component/jms/integration/spring/tx/RouteIdTransactedIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*/
package org.apache.camel.component.jms.integration.spring.tx;

import java.util.concurrent.TimeUnit;

import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.jms.integration.spring.AbstractSpringJMSITSupport;
import org.apache.camel.component.mock.MockEndpoint;
Expand All @@ -27,6 +29,7 @@
import org.junit.jupiter.api.TestMethodOrder;
import org.springframework.context.support.ClassPathXmlApplicationContext;

import static org.awaitility.Awaitility.await;
import static org.junit.jupiter.api.Assertions.assertEquals;

@Tags({ @Tag("not-parallel"), @Tag("spring"), @Tag("tx") })
Expand All @@ -47,7 +50,8 @@ public void testRouteId() throws Exception {

template.sendBody("activemq:queue:RouteIdTransactedTest", "Hello World");

MockEndpoint.assertIsSatisfied(context);
await().atMost(30, TimeUnit.SECONDS)
.untilAsserted(() -> MockEndpoint.assertIsSatisfied(context));
Comment on lines +53 to +54

String id = context.getRouteDefinitions().get(0).getId();
assertEquals("myCoolRoute", id);
Expand All @@ -61,7 +65,8 @@ public void testRouteIdFailed() throws Exception {

template.sendBody("activemq:queue:RouteIdTransactedTest", "Kaboom");

MockEndpoint.assertIsSatisfied(context);
await().atMost(30, TimeUnit.SECONDS)
.untilAsserted(() -> MockEndpoint.assertIsSatisfied(context));
Comment on lines +68 to +69

String id = context.getRouteDefinitions().get(0).getId();
assertEquals("myCoolRoute", id);
Expand Down