BigQuery dialect should escape backslashes in string literals#5094
Open
Samin061 wants to merge 1 commit into
Open
BigQuery dialect should escape backslashes in string literals#5094Samin061 wants to merge 1 commit into
Samin061 wants to merge 1 commit into
Conversation
|
xuzifu666
reviewed
Jul 12, 2026
| .withBigQuery().ok(expectedBigQuery); | ||
| } | ||
|
|
||
| /** Tests that a backslash in a character literal is escaped for BigQuery, |
Member
There was a problem hiding this comment.
Please refer to other PRs: first create a relevant Jira ticket describing the background of the issue, and then update the commit message and the PR details accordingly.
Contributor
There was a problem hiding this comment.
@xuzifu666 I think the policy is that very small fixes don't require a JIRA issue
mihaibudiu
reviewed
Jul 12, 2026
| + "FROM \"foodmart\".\"product\""; | ||
| final String expectedBigQuery = "SELECT 'a\\\\b'\n" | ||
| + "FROM foodmart.product"; | ||
| sql(query) |
Contributor
There was a problem hiding this comment.
I assume you have validated the resulting query using BigQuery?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
No Jira filed yet; happy to open one if preferred. This is a small escaping fix in the SQL generator.
Changes Proposed
BigQuerySqlDialectdeclares its escaped quote as\', but the basequoteStringLiteralonly replaces the quote character, so a literal backslash in a string value reaches BigQuery unescaped. BigQuery treats backslash as an escape character inside string literals, so a pushed-down value such asx\or\'; ...closes the literal early and the trailing characters are parsed as SQL rather than data. OverridequoteStringLiteralto double backslashes before the base method escapes the enclosing quote, so backslash-containing values round-trip as data. Added a rel2sql regression test next totestCharLiteralForBigQuery.