Skip to content

Update to the latest log4j and spotbugs versions #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddanielr wants to merge 10 commits into
base: 2.1
Choose a base branch
from
Open

Update to the latest log4j and spotbugs versions #6486

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4775c6a
Update to the latest log4j and spotbugs versions
ddanielr Jul 21, 2026
f75dffc
Add exclusion filter for spotbugs
ddanielr Jul 21, 2026
ce8dc92
Added private locks and removed exclusion filter
ddanielr Jul 22, 2026
66d14a0
Suppress warnings for run statements
ddanielr Jul 22, 2026
0cb99ce
Added private final locks for sync methods
ddanielr Jul 22, 2026
1350f37
Add filter for ExternalDoNothingCompactor
ddanielr Jul 22, 2026
92a13e3
Add private locks to fix spotbug errors
ddanielr Jul 22, 2026
6ea6b9a
Use zooCacheLock instead of synch on zooCache
ddanielr Jul 22, 2026
a75b59c
Moved lock outside of method call
ddanielr Jul 22, 2026
6f6f294
Suppress warnings in test cases that pass null
ddanielr Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/spotbugs/exclude-filter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,8 @@
<!-- More convenient to ignore these everywhere, because it's very common and unimportant -->
<Bug pattern="JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS" />
</Match>
<Match>
<!-- More convenient to ignore these everywhere, because it's very common in deprecated code -->
<Bug pattern="USO_UNSAFE_STATIC_METHOD_SYNCHRONIZATION" />
</Match>
</FindBugsFilter>
4 changes: 2 additions & 2 deletions core/src/test/java/org/apache/accumulo/core/logging/EscalatingLoggerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ public void test() throws InterruptedException {
// Programatically modify the Log4j2 Logging configuration to add an appender
LoggerContext ctx = LoggerContext.getContext(false);
Configuration cfg = ctx.getConfiguration();
PatternLayout layout = PatternLayout.newBuilder().withConfiguration(cfg)
.withPattern(PatternLayout.SIMPLE_CONVERSION_PATTERN).build();
PatternLayout layout = PatternLayout.newBuilder().setConfiguration(cfg)
.setPattern(PatternLayout.SIMPLE_CONVERSION_PATTERN).build();
Appender appender = WriterAppender.createAppender(layout, null, writer,
"EscalatingLoggerTestAppender", false, true);
appender.start();
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ under the License.
<version.curator>5.8.0</version.curator>
<version.errorprone>2.41.0</version.errorprone>
<version.hadoop>3.3.6</version.hadoop>
<version.log4j>2.25.4</version.log4j>
<version.log4j>2.26.1</version.log4j>
<version.opentelemetry>1.48.0</version.opentelemetry>
<version.powermock>2.0.9</version.powermock>
<version.slf4j>2.0.17</version.slf4j>
Expand Down Expand Up @@ -277,7 +277,7 @@ under the License.
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-annotations</artifactId>
<version>4.9.3</version>
<version>4.10.3</version>
</dependency>
<dependency>
<groupId>com.google.auto.service</groupId>
Expand Down Expand Up @@ -780,7 +780,7 @@ under the License.
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.9.8.2</version>
<version>4.10.3.0</version>
<configuration>
<xmlOutput>true</xmlOutput>
<effort>Max</effort>
Expand Down
4 changes: 4 additions & 0 deletions start/src/main/spotbugs/exclude-filter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,8 @@
<!-- More convenient to ignore these everywhere, because it's very common and unimportant -->
<Bug pattern="JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS" />
</Match>
<Match>
<!-- More convenient to ignore these everywhere, because it's very common in deprecated code -->
<Bug pattern="USO_UNSAFE_STATIC_METHOD_SYNCHRONIZATION" />
</Match>
</FindBugsFilter>
Loading