fix: detect native binary packages as 'unknown' module type - #203
Open
clanzhang wants to merge 1 commit into
Open
fix: detect native binary packages as 'unknown' module type#203clanzhang wants to merge 1 commit into
clanzhang wants to merge 1 commit into
Conversation
Native binding packages (e.g. @oxc-parser/binding-linux-x64-gnu) have a `main` field pointing to a `.node` file. These are not CJS or ESM modules but native binaries. Previously they were incorrectly categorized as CJS. - Detect `.node` files in main/exports and return 'unknown' - Add 'unknown' to PackageModuleTypes and UI display lists Fixes antfu#124
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native binding packages (e.g.
@oxc-parser/binding-linux-x64-gnu) have amainfield pointing to a.nodefile. These are native binaries, not CJS or ESM modules, but were incorrectly categorized as CJS. This PR detects.nodefiles and labels them as'unknown'.Fixes #124
🔗 Linked issue
Resolves #124
🧭 Context
Native binding packages are becoming more common (e.g. SWC, OXC, esbuild). Their
mainfield points to a.nodebinary file. The current detection logic falls through to the default'cjs'return, which is misleading — these packages contain no JavaScript module at all.📚 Description
.nodeextension inmainfield and return'unknown'.nodeinexportsstring analysis (skip without setting import/require flags)'cjs'to'unknown'for packages with no recognizable module entry'unknown'toPackageModuleTypes,MODULE_TYPES_FULL, andMODULE_TYPES_FULL_SELECT@oxc-parser/binding-linux-x64-gnu'cjs'to'unknown'