fix(justfile): guard contracts-publish against non-semver version#545
Open
jonaprieto wants to merge 1 commit into
Open
fix(justfile): guard contracts-publish against non-semver version#545jonaprieto wants to merge 1 commit into
jonaprieto wants to merge 1 commit into
Conversation
jonaprieto
added
bug
`just contracts-publish --dry-run` bound `--dry-run` to the required `version` arg and ran `forge soldeer push anoma-pa-evm~--dry-run` — a real push with a garbage version. Validate that version is semver and fail fast with a usage hint that flags go after the version. Add a `contracts-publish-check` smoke recipe (no network, no publish) and run it in CI so the guard stays effective.
jonaprieto
force-pushed
the
fix/contracts-publish-version-guard
branch
from
46e24f8 to
7f0eedf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
just contracts-publish --dry-runused to bind--dry-runto the requiredversionargument, so it executedforge soldeer push anoma-pa-evm~--dry-run— a real push with a garbage version. This adds a semver check onversionthat fails fast with a usage hint (flags like --dry-run go after the version). No behavior change for correct usage likejust contracts-publish 1.2.0 --dry-run.