compliance merge optimization #220
Merged
Merged
Conversation
- resource.rs: derive_nonce uses big-endian for the index (matching
quantity/PRF bytes); drop unnecessary nf_key.clone() in
ConsumedResourceWitness constructors.
- compliance.rs: rebuild Default's nullifier vec via iter() (drops the
index-2/key-1 typo); collapse the duplicate Resource literals; use
rcv.as_ref(); document accumulate_kind's O(N²) trade-off; fix
typo. Add ComplianceInstance::tags() as the canonical
iterator, used by delta_msg and Action::get_logic_verifiers.
- action.rs: tighten get_logic_verifiers; strengthen
construct_action_tree docs.
- arm_test_app: turn populate_created_resources panic into
ArmError::MissingField; add Tester::{delta_witness, set_created_nonce}
helpers and use them from the relevant tests; add #[ignore]'d
test_aggregation_works_groth16.
XuyangSong
force-pushed
the
enrique/xuyang/compliance_merge
branch
from
c252796 to
10a54c6
Compare
github-project-automation
Bot
moved this from Triage
to Released
in Anoma SDK - What's Cooking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds variable-size compliance unit support, allowing a compliance witness/instance to carry multiple consumed resources and multiple created resources instead of the previous fixed 1:1 consumed/created shape.
Changes
ComplianceWitnessandComplianceInstanceto use lists of consumed and created resource data.Actionto contain a single variable-size compliance unit and match logic verifiers by consumed nullifier / created commitment tags.ComplianceInstanceWordstoVec<u32>.