Add v2 token-transfer crates with migration support#2
Open
XuyangSong wants to merge 2 commits into
Open
Conversation
AHartNtkn
approved these changes
Jun 27, 2026
AHartNtkn
left a comment
There was a problem hiding this comment.
I think this is fine enough to approve. The only real problem I see is most of the tests for v1 (wrap/unwrap/persistent negative tests and overflow unit tests) don't exist for v2. Since v2 is a separate implementation, they are untested. I don't expect any actual failure here; but it is a test suite problem. You may also want to consider moving encode_migrate_forwarder_input to the anoma-pa-solana-client crate to be consistent with encode_wrap_forwarder_input and encode_unwrap_forwarder_input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds v2 of the AnomaPay Solana token-transfer resource: the same wrap/unwrap logic as v1 plus a new Migrate flow for moving a v1 resource into v2. The three v2 crates were ported from the ERC20 resource and adapted to Solana, mirroring their v1 counterparts in this repo.
Follow-ups before deploying v2
The migrate forwarder op byte, instruction-data layout, and account count (
OP_MIGRATE,MIGRATE_FORWARDER_NUM_ACCOUNTS) are provisional and must be reconciled with the deployed v2 SPL token forwarder.