-
Notifications
You must be signed in to change notification settings - Fork 1
test: add integration tests #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heueristik
wants to merge
1
commit into
next
Choose a base branch
from
feature/integration-tests
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # AnomaPay ERC20 Forwarder | ||
|
|
||
| The forwarder contract and integration-test layer for **AnomaPay ERC20**: the | ||
| application that wraps ERC20 tokens on Ethereum into shielded ARM resources, lets | ||
| value move while shielded, and unwraps back to ERC20. | ||
|
|
||
| ## Language | ||
|
|
||
| **AnomaPay ERC20**: | ||
| The application. The umbrella term for the wrap / transfer / unwrap lifecycle of | ||
| shielded ERC20 value. Use this name (not "transfer") for anything that spans more | ||
| than the single shielded-to-shielded action — crates, setups, test files, | ||
| helpers. | ||
| _Avoid_: transfer (as an umbrella for the whole app), shielded token | ||
|
|
||
| **Shielded resource**: | ||
| An ERC20 token's value represented as an ARM resource, no longer held as a plain | ||
| ERC20 balance. | ||
|
|
||
| **Wrap**: | ||
| Lock an ERC20 token and create the corresponding shielded resource. | ||
|
|
||
| **Transfer**: | ||
| Move value from one shielded resource to another — the shielded-to-shielded | ||
| action. "Transfer" names *only* this action, never the app. | ||
|
|
||
| **Unwrap**: | ||
| Consume a shielded resource and release the underlying ERC20 token. | ||
|
|
||
| **Forwarder**: | ||
| The EVM contract through which the protocol adapter drives ERC20 state changes | ||
| (wrap/unwrap) on behalf of AnomaPay ERC20 actions. | ||
|
|
||
| ## Note on upstream names | ||
|
|
||
| `transfer_library`, `transfer_witness`, and the underlying transfer circuit live | ||
| in `anoma/anomapay-erc20-resource` and keep those names — they are immutable from | ||
| this repo's perspective. Do not propagate "transfer" as the umbrella name into | ||
| layers above them (the integration-test crate, scenario setups, helpers); use | ||
| "AnomaPay ERC20" there. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go in a separate PR