accel/amdxdna: initialize ret to -ENOENT in aie tile access helpers#1509
Open
NishadSaraf wants to merge 1 commit into
Open
accel/amdxdna: initialize ret to -ENOENT in aie tile access helpers#1509NishadSaraf wants to merge 1 commit into
NishadSaraf wants to merge 1 commit into
Conversation
Initialize ret to -ENOENT in amdxdna_get_coredump(), amdxdna_aie_tile_read() and amdxdna_aie_tile_write() so that the subsequent 'if (ret == -ENOENT)' check and 'return ret' are well defined even if the amdxdna_for_each_client loop body never executes. This makes each function locally correct instead of relying on the calling client always being present in client_list, and silences static-analysis warnings about reading an uninitialized variable. Signed-off-by: Nishad Saraf <nishads@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the AIE “tile access” and coredump helper paths locally correct by ensuring ret is initialized to -ENOENT before iterating clients, preventing an undefined read when the amdxdna_for_each_client() loop executes zero iterations.
Changes:
- Initialize
retto-ENOENTinamdxdna_get_coredump(). - Initialize
retto-ENOENTinamdxdna_aie_tile_read(). - Initialize
retto-ENOENTinamdxdna_aie_tile_write().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxzhen
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize ret to -ENOENT in amdxdna_get_coredump(), amdxdna_aie_tile_read() and amdxdna_aie_tile_write() so that the subsequent 'if (ret == -ENOENT)' check and 'return ret' are well defined even if the amdxdna_for_each_client loop body never executes. This makes each function locally correct instead of relying on the calling client always being present in client_list, and silences static-analysis warnings about reading an uninitialized variable.