accel/amdxdna: add new device/rev IDs#1494
Open
amd-borpanov wants to merge 3 commits into
Open
Conversation
Member
|
retest this please |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for an additional AMD XDNA NPU generation/revision (“npu10”, PCI rev 0x14) by wiring new firmware metadata and mapping new PCI device/rev IDs to the appropriate per-device configuration structures.
Changes:
- Extend
tools/info.jsonwith firmware download metadata for new PCI device/rev combinations (17f1/17f2, rev 14). - Add
npu10amdxdna_dev_infoentries (classic/PF/VF) and export them via the PCI driver header. - Register new firmware paths and device/revision mappings in the PCI driver.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/info.json | Adds firmware metadata entries for npu10 (PCI rev 14). |
| drivers/accel/amdxdna/npu3_regs.c | Introduces new dev_npu10_*_info device descriptors. |
| drivers/accel/amdxdna/amdxdna_pci_drv.h | Exports the new dev_npu10_*_info symbols. |
| drivers/accel/amdxdna/amdxdna_pci_drv.c | Registers firmware paths and maps (device, rev) to the new npu10 device descriptors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+257
to
+258
| .ops = &aie4_pf_ops, | ||
| }; |
Comment on lines
+269
to
+270
| .ops = &aie4_vf_ops, | ||
| }; |
Comment on lines
+283
to
+284
| .ops = &aie4_classic_ops, | ||
| }; |
Signed-off-by: Borislav Panov <borislav.panov@amd.com>
NishadSaraf
force-pushed
the
add_new_device_ids
branch
from
July 15, 2026 22:11
e44c08e to
6b9a845
Compare
maxzhen
previously approved these changes
Jul 15, 2026
NishadSaraf
requested changes
Jul 16, 2026
NishadSaraf
left a comment
NishadSaraf
left a comment
Member
There was a problem hiding this comment.
Copilot comments are valid. Rest looks good to me
Signed-off-by: Borislav Panov <borislav.panov@amd.com>
Contributor
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.