accel/amdxdna: add query DPM level and DPM frequency table support#1465
Open
donwalkarsoham wants to merge 1 commit into
Open
accel/amdxdna: add query DPM level and DPM frequency table support#1465donwalkarsoham wants to merge 1 commit into
donwalkarsoham wants to merge 1 commit into
Conversation
donwalkarsoham
requested review from
houlz0507,
maxzhen and
xdavidz
as code owners
June 30, 2026 18:00
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves clock/TOPS reporting for the amdxdna AIE4/NPU3 path by adding firmware queries for the current DPM level and the firmware-programmed (per-silicon) DPM frequency tables, then using those to report live domain frequencies.
Changes:
- Add new AIE4 management message opcodes and ABI structs for querying DPM frequency tables and current DPM levels.
- Cache firmware-authoritative DPM frequency tables at probe and use them (plus a live DPM level query) to resolve current AIE/NPU-H frequencies.
- Update clock metadata reporting to rely on refreshed live clock values from
aie_update_counters().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/accel/amdxdna/npu3_regs.c | Update counters to prefer sensor telemetry when available, otherwise query FW DPM level and map to frequency (FW table preferred, static table fallback). |
| drivers/accel/amdxdna/aie4_pci.h | Extend device handle with cached FW DPM tables and add prototypes for new DPM query/init helpers. |
| drivers/accel/amdxdna/aie4_pci.c | Initialize DPM frequency table cache during AIE4 device query and clarify clock metadata reporting. |
| drivers/accel/amdxdna/aie4_msg_priv.h | Define new AIE4 message opcodes and request/response structs for DPM table/level queries. |
| drivers/accel/amdxdna/aie4_message.c | Implement querying/caching of FW DPM frequency tables and querying current FW DPM levels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xdavidz
reviewed
Jul 1, 2026
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
2 times, most recently
from
July 1, 2026 23:30
c38174c to
78678a8
Compare
xdavidz
requested changes
Jul 6, 2026
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
from
July 6, 2026 22:56
78678a8 to
01f6dc8
Compare
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
from
July 7, 2026 16:30
01f6dc8 to
98cd198
Compare
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
from
July 8, 2026 18:49
98cd198 to
0504cfc
Compare
xdavidz
requested changes
Jul 8, 2026
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
3 times, most recently
from
July 15, 2026 19:45
0ba087e to
42c0e80
Compare
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
from
July 15, 2026 23:21
42c0e80 to
7410b30
Compare
xdavidz
approved these changes
Jul 16, 2026
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
from
July 16, 2026 23:12
7410b30 to
02675ed
Compare
Contributor
|
@donwalkarsoham why this is still pending? I need this to test SR-IOV TOPs. |
Contributor
|
retest this please |
NishadSaraf
previously approved these changes
Jul 17, 2026
xdavidz
previously approved these changes
Jul 17, 2026
maxzhen
previously approved these changes
Jul 17, 2026
donwalkarsoham
dismissed stale reviews from maxzhen, xdavidz, and NishadSaraf
via
July 17, 2026 23:04
586f155
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
from
July 17, 2026 23:04
02675ed to
586f155
Compare
Signed-off-by: Soham Donwalkar <Soham.Donwalkar@amd.com>
donwalkarsoham
force-pushed
the
xrt-smi-validate-dpm
branch
from
July 17, 2026 23:09
586f155 to
626a6cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.