Skip to content

ci(labeler): add tui/daemon/sidecar auto-label rules#2356

Merged
kovtcharov-amd merged 1 commit into
mainfrom
ci/labeler-tui-daemon-sidecar
Jul 21, 2026
Merged

ci(labeler): add tui/daemon/sidecar auto-label rules#2356
kovtcharov-amd merged 1 commit into
mainfrom
ci/labeler-tui-daemon-sidecar

Conversation

@kovtcharov-amd

Copy link
Copy Markdown
Collaborator

Why this matters

The terminal-hub / sidecar architecture work (milestone #45) added new code surfaces the auto-labeler didn't know about, so PRs touching the Go TUI, the daemon supervisor, or the agent sidecar contract landed unlabelled and had to be triaged by hand. This teaches actions/labeler about those paths and introduces the matching tui / daemon / sidecar repo labels (already created), so future PRs in these areas self-label.

Test plan

  • labeler.yml parses as valid YAML and every referenced label exists as a repo label.
  • A PR touching tui/** (or .github/workflows/build_tui.yml) receives the tui label.
  • A PR touching src/gaia/daemon/** receives the daemon label.
  • A PR touching src/gaia/daemon/sidecars/** or hub/agents/*/python/packaging/** receives the sidecar label.

No change to auto-label.yml — it's generic (actions/labeler@v6, no per-label config), so the new rules take effect on next PR event.

Auto-labeling didn't cover the terminal-hub or daemon/sidecar surfaces
scoped into milestone #45, so PRs touching the Go TUI, the daemon
supervisor, or the agent sidecar contract landed unlabelled and had to be
triaged by hand.

Add rules mapping tui/** and the TUI build workflow to `tui`,
src/gaia/daemon/** to `daemon`, and the sidecar contract paths to
`sidecar` (the repo labels were created alongside this change).
@github-actions github-actions Bot added the devops DevOps/infrastructure changes label Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Verdict: Approve

Adds three auto-label rules (tui, daemon, sidecar) so PRs touching the terminal-hub/sidecar surfaces self-label instead of needing manual triage. All the referenced paths (tui/, src/gaia/daemon/, src/gaia/daemon/sidecars/, build_tui.yml, hub/agents/*/python/packaging/) exist today, the YAML parses cleanly, and the new blocks mirror the file's existing changed-files / any-glob-to-any-file structure. No blocking issues — ready to merge.

🔍 Technical details

Verification

  • YAML parses (yaml.safe_load) ✅
  • Every referenced path resolves in the current tree — tui/, src/gaia/daemon/, src/gaia/daemon/sidecars/, .github/workflows/build_tui.yml, and at least one hub/agents/*/python/packaging/ (email) — so no globs are dead on arrival.
  • Structure matches the surrounding rules exactly; placement between the talk area rule and the hub-agent block is consistent with the file's ordering.

Non-blocking observations (no action needed)

  • 🟢 sidecar (src/gaia/daemon/sidecars/**) is a subset of daemon (src/gaia/daemon/**), so files under sidecars/ receive both daemon and sidecar. Likewise hub/agents/*/python/packaging/** overlaps the matching agent::<id> label. This is the same intentional multi-label overlap already used by performance/llm/rag, so it's fine — just noting it's expected behavior, not a bug.

Strengths

  • Forward-looking globs are all backed by real paths, and the test plan explicitly confirms the labels already exist as repo labels — avoids the common labeler failure mode of referencing a label that was never created.
  • Clear comment block documents the milestone context and placement rationale.

@kovtcharov-amd
kovtcharov-amd requested a review from itomek July 21, 2026 01:48
@kovtcharov-amd
kovtcharov-amd enabled auto-merge July 21, 2026 01:48
@kovtcharov-amd
kovtcharov-amd added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 4b5c16b Jul 21, 2026
23 checks passed
@kovtcharov-amd
kovtcharov-amd deleted the ci/labeler-tui-daemon-sidecar branch July 21, 2026 12:39
@itomek itomek mentioned this pull request Jul 22, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops DevOps/infrastructure changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants