Skip to content

Fixes for newer kernels. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvdillon wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for newer kernels. #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00e08bd
Fixes for newer kernels.
jvdillon Sep 19, 2025
c574bb3
Fixes for newer kernels.
jvdillon Sep 19, 2025
5cf7f4c
Fixes for newer kernels.
jvdillon Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apml_alertl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/i3c/device.h>
#include <linux/i3c/master.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_gpio.h>
Expand Down Expand Up @@ -246,15 +247,14 @@ static int apml_alertl_probe(struct platform_device *pdev)
return 0;
}

static int alert_remove(struct platform_device *pdev)
static void alert_remove(struct platform_device *pdev)

@akky16 akky16 Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be on basis of Linux kernel version

{
#ifdef CONFIG_DEBUG_FS
if (amd_apml) {
debugfs_remove_recursive(amd_apml);
amd_apml = NULL;
}
#endif
return 0;
}

static const struct of_device_id apml_alertl_dt_ids[] = {
Expand Down
2 changes: 1 addition & 1 deletion apml_sbtsi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ static int sbtsi_i3c_probe(struct i3c_device *i3cdev)
struct regmap *regmap;
const char *name;

regmap = devm_regmap_init_i3c(i3cdev, &sbtsi_i3c_regmap_config);
regmap = devm_regmap_init_i2c(i3cdev, &sbtsi_i3c_regmap_config);
if (IS_ERR(regmap)) {

@akky16 akky16 Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

dev_err(&i3cdev->dev, "Failed to register i3c regmap %d\n",
(int)PTR_ERR(regmap));
Expand Down
2 changes: 1 addition & 1 deletion sbrmi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ static int init_rmi_regmap(struct apml_sbrmi_device *rmi_dev, u32 size, u32 rev)
struct regmap *regmap;

if (rmi_dev->i3cdev) {
regmap = devm_regmap_init_i3c(rmi_dev->i3cdev,
regmap = devm_regmap_init_i2c(rmi_dev->i3cdev,

@akky16 akky16 Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

&sbrmi_regmap_config);
if (IS_ERR(regmap)) {
dev_err(&rmi_dev->i3cdev->dev,
Expand Down