Skip to content

fix(inkless): bound error-message size on fetch/commit failure paths [KC-410] #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeqo merged 1 commit into from
Aug 13, 2026
Merged

fix(inkless): bound error-message size on fetch/commit failure paths [KC-410] #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion storage/inkless/src/main/java/io/aiven/inkless/consume/FetchCompleter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ public Map<TopicIdPartition, FetchPartitionData> get() {
metrics.recordFetchResponseSize(totalBytes);
return result;
} catch (Exception e) {
throw new FetchException("Failed to complete fetch for partitions " + fetchInfos.keySet(), e);
// Only the partition count: fetchInfos can span thousands of client-requested
// partitions, so interpolating the full key set here would build an unbounded string.
throw new FetchException("Failed to complete fetch for " + fetchInfos.size() + " partitions", e);
}
}

Expand Down
5 changes: 4 additions & 1 deletion storage/inkless/src/main/java/io/aiven/inkless/produce/FileCommitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,10 @@ void commit(final ClosedFile file) throws InterruptedException {
totalBytesInProgress.addAndGet(-file.size());
if (error != null) {
// at this point the commit has failed and need to check whether it failed on upload or commit
LOGGER.error("Failed to commit diskless file {}", file, error);
// Log a bounded summary: ClosedFile.toString() would dump every aggregated
// request/batch, an unbounded string on this error path.
LOGGER.error("Failed to commit diskless file (start={}, requests={}, batches={}, bytes={})",
file.start(), file.originalRequests().size(), file.commitBatchRequests().size(), file.size(), error);
if (error.getCause() instanceof FileUploadException) {
metrics.fileUploadFailed();
} else {
Expand Down
Loading