Skip to content

dist: Support Tencent Kona JDK#672

Merged
brunoborges merged 5 commits into
actions:mainfrom
johnshajiang:support-kona-jdk
Jul 7, 2026
Merged

dist: Support Tencent Kona JDK#672
brunoborges merged 5 commits into
actions:mainfrom
johnshajiang:support-kona-jdk

Conversation

@johnshajiang

@johnshajiang johnshajiang commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

Description:
This PR adds Tencent Kona JDK into setup-java.
It supports the major versions 8, 11, 17 and 21.
The supported platforms are Linux x86_64/aarch64, macOS x86_64/aarch64 and Windows x86_64.

Currently, only the latest stable releases are supported, and only jdk (no jre) binaries are available.
A configuration maintains these releases.

Related issue:
#671

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@johnshajiang johnshajiang requested a review from a team as a code owner August 14, 2024 03:48
@johnshajiang

Copy link
Copy Markdown
Contributor Author

I just refreshed the commit.
It resolved the file conflicts and supported Tencent Kona JDK 21.

@johnshajiang

Copy link
Copy Markdown
Contributor Author

I just updated the commit again, and the file conflicts are resolved.

@johnshajiang johnshajiang force-pushed the support-kona-jdk branch 3 times, most recently from 41ce0ca to 109744b Compare February 13, 2025 08:31
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
@johnshajiang

johnshajiang commented Feb 13, 2025

Copy link
Copy Markdown
Contributor Author

I already executed npm run build for re-generating the index.js files, and committed them.

> setup-java@4.0.0 build
> ncc build -o dist/setup src/setup-java.ts && ncc build -o dist/cleanup src/cleanup-java.ts

ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.3.3 (local user-provided)
5204kB  dist/setup/index.js
5204kB  [2160ms] - ncc 0.38.1
ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.3.3 (local user-provided)
3777kB  dist/cleanup/index.js
3777kB  [1804ms] - ncc 0.38.1

But Check dist check task always failed.

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 14, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
@brunoborges brunoborges added feature request New feature or request to improve the current logic distribution JDK distribution/version/source support and removed feature request New feature or request to improve the current logic labels Jun 22, 2026
@brunoborges

Copy link
Copy Markdown
Contributor

Linking the tracking issue: this PR implements #671 (Tencent Kona JDK support). Maintainers — adding Closes #671 to the PR description will auto-close the issue on merge.

@brunoborges brunoborges added the stale The issue has been open for a year without any activity label Jun 23, 2026
@brunoborges brunoborges changed the title Support Tencent Kona JDK dist: Support Tencent Kona JDK Jun 23, 2026
brunoborges pushed a commit to johnshajiang/actions-setup-java that referenced this pull request Jun 23, 2026
Signed-off-by: John Jiang <johnsjiang@tencent.com>
@brunoborges brunoborges requested a review from Copilot June 23, 2026 19:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the Tencent Kona JDK distribution to actions/setup-java, including the installer implementation, documentation, and test/e2e coverage.

Changes:

  • Add a new KonaDistribution that resolves Kona JDK downloads from the published kona-v1.json configuration.
  • Register the new kona distribution in the distribution factory and bundled dist output.
  • Update docs, e2e matrix, and add unit tests + fixture manifest data for Kona.
Show a summary per file
File Description
src/distributions/kona/models.ts Adds Kona release/config TypeScript models.
src/distributions/kona/installer.ts Implements Kona distribution resolution and download/extract logic.
src/distributions/distribution-factory.ts Registers kona as a supported distribution and wires installer creation.
README.md Documents kona as a supported distribution and links to advanced usage.
docs/advanced-usage.md Adds a “Tencent Kona” usage section and TOC entry.
__tests__/distributors/kona-installer.test.ts Adds unit tests for Kona release selection and error cases.
__tests__/data/kona.json Adds fixture manifest data used by the Kona unit tests.
.github/workflows/e2e-versions.yml Adds kona to the e2e distribution matrix.
dist/setup/index.js Updates the bundled action output to include the new Kona installer.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 8/9 changed files
  • Comments generated: 5

Comment thread src/distributions/kona/installer.ts
Comment thread src/distributions/kona/installer.ts
Comment thread src/distributions/kona/installer.ts
Comment thread src/distributions/kona/installer.ts Outdated
Comment thread src/distributions/kona/installer.ts
Signed-off-by: John Jiang <johnsjiang@tencent.com>
@johnshajiang

Copy link
Copy Markdown
Contributor Author

@brunoborges
Thank you for picking this PR back up and updating it.
Is there anything else you need from me?

brunoborges
brunoborges previously approved these changes Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 8/9 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment thread src/distributions/kona/installer.ts
Comment thread src/distributions/kona/installer.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
brunoborges and others added 2 commits July 7, 2026 10:09
- Sort matching releases by semver descending so range versions (e.g. >=17) resolve to the newest matching Kona JDK instead of the lowest
- Rename downloaded archive on Windows before extraction (renameWinArchive) to avoid extraction failures
- Import semver for version sorting

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
brunoborges
brunoborges previously approved these changes Jul 7, 2026
@brunoborges brunoborges merged commit a50fdcc into actions:main Jul 7, 2026
402 checks passed
@johnshajiang

Copy link
Copy Markdown
Contributor Author

@brunoborges
Thank your every much for supporting Tencent Kona JDK!

brunoborges added a commit to lukaszgyg/setup-java that referenced this pull request Jul 7, 2026
- Map SDKMAN 'kona' identifier to the 'kona' distribution (added in actions#672)
- Add a .sdkmanrc test case for the kona suffix
- Convert the inline SDKMAN suffix mapping in advanced-usage.md to a table
- Rebuild dist bundles

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
brunoborges added a commit that referenced this pull request Jul 7, 2026
* feat: Add distribution detection support to .sdkmanrc file

Extends .sdkmanrc support to automatically detect Java distribution from SDKMAN identifiers (e.g., java=21.0.5-tem maps to temurin distribution).

Makes distribution input optional when using .sdkmanrc with distribution suffix.

* fix: align SDKMAN sem identifier mapping

* fix: support SDKMAN albba identifier

* docs: clarify sdkmanrc distribution inference scope

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add Tencent Kona SDKMAN mapping and format sdkmanrc docs as a table

- Map SDKMAN 'kona' identifier to the 'kona' distribution (added in #672)
- Add a .sdkmanrc test case for the kona suffix
- Convert the inline SDKMAN suffix mapping in advanced-usage.md to a table
- Rebuild dist bundles

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Bruno Borges <brborges@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Bruno Borges <bruno.borges@gmail.com>
mergify Bot added a commit to ArcadeData/arcadedb that referenced this pull request Jul 8, 2026
Bumps the github-actions group with 2 updates: [actions/setup-java](https://github.com/actions/setup-java) and [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action).
Updates `actions/setup-java` from 5.4.0 to 5.5.0
Release notes

*Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).*

> v5.5.0
> ------
>
> What's Changed
> --------------
>
> * chore: enforce pre-PR validation (aggregate scripts, git hooks, PR checklist) by [`@​brunoborges`](https://github.com/brunoborges) in [actions/setup-java#1061](https://redirect.github.com/actions/setup-java/pull/1061)
> * Bump github/codeql-action from 3 to 4 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#1069](https://redirect.github.com/actions/setup-java/pull/1069)
> * Bump actions/checkout from 6 to 7 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#1068](https://redirect.github.com/actions/setup-java/pull/1068)
> * Bump actions/setup-python from 5 to 6 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#1067](https://redirect.github.com/actions/setup-java/pull/1067)
> * Bump `@​typescript-eslint/parser` from 8.61.1 to 8.62.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#1062](https://redirect.github.com/actions/setup-java/pull/1062)
> * feat: Add verify-signature plumbing and Temurin+Microsoft verification support by [`@​johnoliver`](https://github.com/johnoliver) in [actions/setup-java#1060](https://redirect.github.com/actions/setup-java/pull/1060)
> * Updated jetbrains test: https.request() now catches errors. This fixes leaking tests as well by [`@​jmjaffe37`](https://github.com/jmjaffe37) in [actions/setup-java#1070](https://redirect.github.com/actions/setup-java/pull/1070)
> * Fix arm64 e2e workflow tests mislabeled as x64 by [`@​brunoborges`](https://github.com/brunoborges) with [`@​Copilot`](https://github.com/Copilot) in [actions/setup-java#1073](https://redirect.github.com/actions/setup-java/pull/1073)
> * feat: suppress Maven transfer progress via MAVEN\_ARGS by default (add show-download-progress input) by [`@​brunoborges`](https://github.com/brunoborges) in [actions/setup-java#1053](https://redirect.github.com/actions/setup-java/pull/1053)
> * feat: Disable interactiveMode in generated Maven settings.xml by [`@​brunoborges`](https://github.com/brunoborges) with [`@​Copilot`](https://github.com/Copilot) in [actions/setup-java#1052](https://redirect.github.com/actions/setup-java/pull/1052)
> * Bump prettier from 3.6.2 to 3.9.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#1066](https://redirect.github.com/actions/setup-java/pull/1066)
> * chore(deps-dev): bump eslint-plugin-jest from 29.0.1 to 29.15.4 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#1074](https://redirect.github.com/actions/setup-java/pull/1074)
> * fix: Maven Toolchains grows unexpectedly by [`@​Okeanos`](https://github.com/Okeanos) in [actions/setup-java#534](https://redirect.github.com/actions/setup-java/pull/534)
> * dist: Support Tencent Kona JDK by [`@​johnshajiang`](https://github.com/johnshajiang) in [actions/setup-java#672](https://redirect.github.com/actions/setup-java/pull/672)
> * feat: Add set-default option by [`@​gsmet`](https://github.com/gsmet) in [actions/setup-java#1017](https://redirect.github.com/actions/setup-java/pull/1017)
> * docs: document problem matcher (and how to disable it), Maven Wrapper caching, and generated interactiveMode by [`@​brunoborges`](https://github.com/brunoborges) in [actions/setup-java#1075](https://redirect.github.com/actions/setup-java/pull/1075)
> * feat: Add distribution detection support to .sdkmanrc file by [`@​lukaszgyg`](https://github.com/lukaszgyg) in [actions/setup-java#975](https://redirect.github.com/actions/setup-java/pull/975)
>
> New Contributors
> ----------------
>
> * [`@​jmjaffe37`](https://github.com/jmjaffe37) made their first contribution in [actions/setup-java#1070](https://redirect.github.com/actions/setup-java/pull/1070)
> * [`@​gsmet`](https://github.com/gsmet) made their first contribution in [actions/setup-java#1017](https://redirect.github.com/actions/setup-java/pull/1017)
> * [`@​lukaszgyg`](https://github.com/lukaszgyg) made their first contribution in [actions/setup-java#975](https://redirect.github.com/actions/setup-java/pull/975)
>
> **Full Changelog**: <actions/setup-java@v5...v5.5.0>


Commits

* [`0f481fc`](actions/setup-java@0f481fc) feat: Add distribution detection support to .sdkmanrc file ([#975](https://redirect.github.com/actions/setup-java/issues/975))
* [`c4922bf`](actions/setup-java@c4922bf) docs: document problem matcher (and how to disable it), Maven Wrapper caching...
* [`6657b99`](actions/setup-java@6657b99) feat: Add set-default option ([#1017](https://redirect.github.com/actions/setup-java/issues/1017))
* [`a50fdcc`](actions/setup-java@a50fdcc) dist: Support Tencent Kona JDK ([#672](https://redirect.github.com/actions/setup-java/issues/672))
* [`77ee41d`](actions/setup-java@77ee41d) fix: Maven Toolchains grows unexpectedly ([#534](https://redirect.github.com/actions/setup-java/issues/534))
* [`0765b15`](actions/setup-java@0765b15) chore(deps-dev): bump eslint-plugin-jest from 29.0.1 to 29.15.4 ([#1074](https://redirect.github.com/actions/setup-java/issues/1074))
* [`c712b2f`](actions/setup-java@c712b2f) Bump prettier from 3.6.2 to 3.9.1 ([#1066](https://redirect.github.com/actions/setup-java/issues/1066))
* [`733efae`](actions/setup-java@733efae) feat: Disable interactiveMode in generated Maven settings.xml ([#1052](https://redirect.github.com/actions/setup-java/issues/1052))
* [`6c4d4a5`](actions/setup-java@6c4d4a5) feat: suppress Maven transfer progress via MAVEN\_ARGS by default (add show-do...
* [`324b333`](actions/setup-java@324b333) Fix arm64 e2e workflow tests mislabeled as x64 ([#1073](https://redirect.github.com/actions/setup-java/issues/1073))
* Additional commits viewable in [compare view](actions/setup-java@1bcf9fb...0f481fc)
  
Updates `anthropics/claude-code-action` from 1.0.165 to 1.0.168
Release notes

*Sourced from [anthropics/claude-code-action's releases](https://github.com/anthropics/claude-code-action/releases).*

> v1.0.168
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.168>
>
> v1.0.167
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.167>
>
> v1.0.166
> --------
>
> What's Changed
> --------------
>
> * Drop buffered inline comment when it is posted live ([#1405](https://redirect.github.com/anthropics/claude-code-action/issues/1405)) by [`@​archievi`](https://github.com/archievi) in [anthropics/claude-code-action#1412](https://redirect.github.com/anthropics/claude-code-action/pull/1412)
> * Use modern noreply email for co-author trailers by [`@​tarunag10`](https://github.com/tarunag10) in [anthropics/claude-code-action#1369](https://redirect.github.com/anthropics/claude-code-action/pull/1369)
> * fix(restore): handle symlinked CLAUDE.md paths during config snapshot by [`@​syf2211`](https://github.com/syf2211) in [anthropics/claude-code-action#1441](https://redirect.github.com/anthropics/claude-code-action/pull/1441)
> * fix: preserve repeated add-dir flags in claude args by [`@​Jerry2003826`](https://github.com/Jerry2003826) in [anthropics/claude-code-action#1256](https://redirect.github.com/anthropics/claude-code-action/pull/1256)
> * fix: propagate curl failures in install pipeline by [`@​akhilesharora`](https://github.com/akhilesharora) in [anthropics/claude-code-action#1241](https://redirect.github.com/anthropics/claude-code-action/pull/1241)
> * chore: fix prettier formatting by [`@​ashwin-ant`](https://github.com/ashwin-ant) in [anthropics/claude-code-action#1463](https://redirect.github.com/anthropics/claude-code-action/pull/1463)
>
> New Contributors
> ----------------
>
> * [`@​archievi`](https://github.com/archievi) made their first contribution in [anthropics/claude-code-action#1412](https://redirect.github.com/anthropics/claude-code-action/pull/1412)
> * [`@​syf2211`](https://github.com/syf2211) made their first contribution in [anthropics/claude-code-action#1441](https://redirect.github.com/anthropics/claude-code-action/pull/1441)
> * [`@​akhilesharora`](https://github.com/akhilesharora) made their first contribution in [anthropics/claude-code-action#1241](https://redirect.github.com/anthropics/claude-code-action/pull/1241)
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.166>


Commits

* [`ba0aafd`](anthropics/claude-code-action@ba0aafd) chore: bump Claude Code to 2.1.204 and Agent SDK to 0.3.204
* [`0fe28cd`](anthropics/claude-code-action@0fe28cd) chore: bump Claude Code to 2.1.203 and Agent SDK to 0.3.203
* [`f87768c`](anthropics/claude-code-action@f87768c) chore: bump Claude Code to 2.1.202 and Agent SDK to 0.3.202
* [`58a2944`](anthropics/claude-code-action@58a2944) chore: fix prettier formatting ([#1463](https://redirect.github.com/anthropics/claude-code-action/issues/1463))
* [`beb753e`](anthropics/claude-code-action@beb753e) fix: propagate curl failures in install pipeline ([#1241](https://redirect.github.com/anthropics/claude-code-action/issues/1241))
* [`235b39b`](anthropics/claude-code-action@235b39b) fix: preserve repeated add-dir flags in claude args ([#1256](https://redirect.github.com/anthropics/claude-code-action/issues/1256))
* [`d060ddc`](anthropics/claude-code-action@d060ddc) fix(restore): handle symlinked CLAUDE.md paths during config snapshot ([#1441](https://redirect.github.com/anthropics/claude-code-action/issues/1441))
* [`0f07aee`](anthropics/claude-code-action@0f07aee) Use modern noreply email for co-author trailers ([#1369](https://redirect.github.com/anthropics/claude-code-action/issues/1369))
* [`a221ad2`](anthropics/claude-code-action@a221ad2) Drop buffered inline comment when it is posted live ([#1405](https://redirect.github.com/anthropics/claude-code-action/issues/1405)) ([#1412](https://redirect.github.com/anthropics/claude-code-action/issues/1412))
* See full diff in [compare view](anthropics/claude-code-action@558b1d6...ba0aafd)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distribution JDK distribution/version/source support stale The issue has been open for a year without any activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants