[PROTOTYPE] Add analyzer-only ABSL_ANALYZER_ASSUME primitive and consume it in the nullability checker - #1159
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
[PROTOTYPE] Add analyzer-only ABSL_ANALYZER_ASSUME primitive and consume it in the nullability checker#1159copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…ume it in the nullability checker Introduces a single, analyzer-only primitive `ABSL_ANALYZER_ASSUME(cond)` in Abseil that feeds a fact to Clang dataflow-based analyses and expands to nothing in production builds. The nullability checker recognizes it once and calls `Env.assume(...)`, so error-checking macros can teach analyses a fact (e.g. non-nullness after `CHECK_NE(p, nullptr)`) by emitting the shared primitive instead of each carrying its own analyzer workaround. Wires up Abseil `CHECK_OP`/`QCHECK_OP` to emit it under analysis (production expansion unchanged). Prototype for discussion. PiperOrigin-RevId: 961780215
copybara-service
Bot
force-pushed
the
test_961780215
branch
from
August 10, 2026 09:38
df6bc12 to
598d523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[PROTOTYPE] Add analyzer-only ABSL_ANALYZER_ASSUME primitive and consume it in the nullability checker
Introduces a single, analyzer-only primitive
ABSL_ANALYZER_ASSUME(cond)inAbseil that feeds a fact to Clang dataflow-based analyses and expands to nothing
in production builds. The nullability checker recognizes it once and calls
Env.assume(...), so error-checking macros can teach analyses a fact (e.g.non-nullness after
CHECK_NE(p, nullptr)) by emitting the shared primitiveinstead of each carrying its own analyzer workaround. Wires up Abseil
CHECK_OP/QCHECK_OPto emit it under analysis (production expansionunchanged). Prototype for discussion.