Check supports_dynamic_linker feature when setting disallow_dynamic_library - #1152
Merged
Conversation
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_961130661
branch
2 times, most recently
from
August 13, 2026 15:33
c784b37 to
9bfc3fa
Compare
…ibrary The implementation of cc_library considers that feature when setting the disallow_dynamic_library parameter of cc_common.create_linking_context_from_compilation_outputs: https://github.com/bazelbuild/rules_cc/blob/cd5e6f294b660b8ffbfd2f187aad01d47d446acd/cc/private/rules_impl/cc_library_impl.bzl#L92 That's documented in the well-known-features for cc_toolchain here: https://bazel.build/docs/cc-toolchain-config-reference#wellknown-features PiperOrigin-RevId: 964113580
copybara-service
Bot
force-pushed
the
test_961130661
branch
from
August 13, 2026 15:58
9bfc3fa to
bc08c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check supports_dynamic_linker feature when setting disallow_dynamic_library
The implementation of cc_library considers that feature when setting the disallow_dynamic_library parameter of cc_common.create_linking_context_from_compilation_outputs:
https://github.com/bazelbuild/rules_cc/blob/cd5e6f294b660b8ffbfd2f187aad01d47d446acd/cc/private/rules_impl/cc_library_impl.bzl#L92
That's documented in the well-known-features for cc_toolchain here:
https://bazel.build/docs/cc-toolchain-config-reference#wellknown-features