Skip to content

feat: check if pool supports multicall - #3096

Open
grothem wants to merge 1 commit into
mainfrom
fix/multicall-check
Open

feat: check if pool supports multicall#3096
grothem wants to merge 1 commit into
mainfrom
fix/multicall-check

Conversation

@grothem

@grothem grothem commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Checks the POOL_REVISION to know if multi call is supported or not. Since some markets don't, we can't enable the 'supply and enter emode and/or enable collateral' functionality.

@odin-by-borg

odin-by-borg Bot commented Aug 28, 2026

Copy link
Copy Markdown

Mjolnir Security Review

VerdictCLEAN · 0 findings
Commit3af548e · 1m 11s

No security vulnerabilities identified in the reviewed changes. The PR adds a capability-detection hook (usePoolSupportsMulticall) that queries on-chain pool revision and gracefully falls back to sequential transactions when multicall is unavailable. The fallback to false on any error is the safe, conservative default. The sequential transaction path introduces non-atomicity (first tx succeeds, second may fail), but this is an inherent design trade-off for pools without multicall support, not a security vulnerability — on-chain smart contract invariants still protect user funds. The SupplyActions change also correctly extends the native-asset + emode-switch path to honour permit-based supply, which is a positive improvement.

View in Odin


15 PRs reviewed · 1 finding

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
interface Ready Ready Preview Aug 28, 2026 7:32pm

Request Review

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant