Update wp-coding-standards/wpcs to 3.4.1 - #588
Open
obenland wants to merge 1 commit into
Open
Conversation
Bumps the constraint from ^2.3 to ^3.4.1 and regenerates composer.lock. Replaces WordPress.CodeAnalysis.EmptyStatement (removed in WPCS 3.0) with its upstreamed equivalent Generic.CodeAnalysis.EmptyPHPStatement. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates off the WPCS 2.x pin:
^2.3to^3.4.1and regeneratescomposer.lock.WordPress.CodeAnalysis.EmptyStatement(removed in WPCS 3.0) with its upstreamed PHPCS equivalentGeneric.CodeAnalysis.EmptyPHPStatementinphpcs.xml.dist— with the old reference, phpcs 3.x refuses to run.CI runs phpunit only (
composer run test), so this has no CI impact; thecomposer lintscript works again after this change (it currently dies on the removed sniff once WPCS 3 is installed).Part of an org-wide sweep to get all repos onto WPCS 3.4.1.
🤖 Generated with Claude Code
Note on CI: the Test Suite failures ("Install WordPress and initialize database", exit 127) are pre-existing — yesterday's Dependabot PRs fail the same step. Unrelated to this change.