Skip to content

Prevent duplicate Quick Edit save requests #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArkaPrabhaChowdhury wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Prevent duplicate Quick Edit save requests #12869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09bbfae
Prevent duplicate Quick Edit saves
ArkaPrabhaChowdhury Aug 6, 2026
84b1845
Merge branch 'trunk' into trac-25696-inline-edit-lock
ArkaPrabhaChowdhury Aug 6, 2026
3e3dcd3
Document inline edit save state
ArkaPrabhaChowdhury Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/js/_enqueues/admin/inline-edit-post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,20 @@ window.wp = window.wp || {};
*
* @property {string} type The type of inline editor.
* @property {string} what The prefix before the post ID.
* @property {boolean} saving Whether a save request is active.
*
*/
( function( $, wp ) {

window.inlineEditPost = {

/**
* Whether a save request is active.
*
* @type {boolean}
*/
saving: false,

/**
* Initializes the inline and bulk post editor.
*
Expand Down Expand Up @@ -488,6 +496,11 @@ window.wp = window.wp || {};
save : function(id) {
var params, fields, page = $('.post_status_page').val() || '';

if ( this.saving ) {
return false;
}
this.saving = true;

if ( typeof(id) === 'object' ) {
id = this.getId(id);
}
Expand Down Expand Up @@ -536,7 +549,10 @@ window.wp = window.wp || {};
wp.a11y.speak( wp.i18n.__( 'Error while saving the changes.' ) );
}
},
'html');
'html'
).always( function() {
inlineEditPost.saving = false;
} );

// Prevent submitting the form when pressing Enter on a focused field.
return false;
Expand Down
15 changes: 14 additions & 1 deletion src/js/_enqueues/admin/inline-edit-tax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ window.wp = window.wp || {};
( function( $, wp ) {

window.inlineEditTax = {
/**
* Whether a save request is active.
*
* @type {boolean}
*/
saving: false,

/**
* Initializes the inline taxonomy editor by adding event handlers to be able to
Expand Down Expand Up @@ -167,6 +173,11 @@ window.inlineEditTax = {
save : function(id) {
var params, fields, tax = $('input[name="taxonomy"]').val() || '';

if ( this.saving ) {
return false;
}
this.saving = true;

// Makes sure we can pass an HTMLElement as the ID.
if( typeof(id) === 'object' ) {
id = this.getId(id);
Expand Down Expand Up @@ -242,7 +253,9 @@ window.inlineEditTax = {
wp.a11y.speak( wp.i18n.__( 'Error while saving the changes.' ) );
}
}
);
).always( function() {
inlineEditTax.saving = false;
} );

// Prevent submitting the form when pressing Enter on a focused field.
return false;
Expand Down
4 changes: 4 additions & 0 deletions tests/qunit/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
<body>
<div id="qunit"></div>
<div id="qunit-fixture">
<table id="the-list" data-wp-lists="list:tag"><tbody></tbody></table>
<script src="fixtures/customize-header.js"></script>
<script src="fixtures/customize-settings.js"></script>
<script src="fixtures/customize-menus.js"></script>
Expand All @@ -90,6 +91,8 @@
<script src="../../build/wp-admin/js/dashboard.js"></script>
<script src="../../build/wp-admin/js/password-strength-meter.js"></script>
<script src="../../build/wp-admin/js/postbox.js"></script>
<script src="../../build/wp-admin/js/inline-edit-post.js"></script>
<script src="../../build/wp-admin/js/inline-edit-tax.js"></script>
<script src="../../build/wp-includes/js/dist/vendor/moment.js"></script>
<script src="../../build/wp-includes/js/dist/date.js"></script>
<script src="../../build/wp-includes/js/dist/i18n.js"></script>
Expand Down Expand Up @@ -147,6 +150,7 @@

<!-- Unit tests -->
<script src="wp-admin/js/password-strength-meter.js"></script>
<script src="wp-admin/js/inline-edit.js"></script>
<script src="wp-admin/js/theme.js"></script>
<script src="wp-admin/js/customize-base.js"></script>
<script src="wp-admin/js/customize-header.js"></script>
Expand Down
19 changes: 19 additions & 0 deletions tests/qunit/wp-admin/js/inline-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/* global QUnit, inlineEditPost, inlineEditTax */

( function() {
'use strict';

QUnit.module( 'wp.inlineEdit' );

QUnit.test( 'Duplicate post saves are ignored while a request is active', function( assert ) {
inlineEditPost.saving = true;
assert.strictEqual( inlineEditPost.save( 1 ), false, 'A duplicate post save is ignored.' );
inlineEditPost.saving = false;
} );

QUnit.test( 'Duplicate taxonomy saves are ignored while a request is active', function( assert ) {
inlineEditTax.saving = true;
assert.strictEqual( inlineEditTax.save( 1 ), false, 'A duplicate taxonomy save is ignored.' );
inlineEditTax.saving = false;
} );
} )();
Loading