Administration: Remove unreachable "All selected plugins are up to date." notice in plugins.php

[aminurislamarnob]

Trac ticket: https://core.trac.wordpress.org/ticket/65812

Summary

Removes an unreachable admin-notice branch on the Plugins screen (wp-admin/plugins.php). The elseif ( 'update-selected' === $action ) branch that prints "All selected plugins are up to date." can never execute.

Why it is unreachable

• $action is assigned once, from WP_Plugins_List_Table::current_action(), and is never reassigned.
• When $action === 'update-selected', the earlier switch ( $action ) enters case 'update-selected':, which renders the bulk-update iframe and ends in an unconditional exit;.
• Execution therefore never reaches the notice chain while $action === 'update-selected', so the elseif is always false. PHPStan reports the comparison as "will always evaluate to false."

The string "All selected plugins are up to date." exists nowhere else in wp-admin, and the iframe update screen (update.php?action=update-selected) already reports the up-to-date outcome.

History

The branch was reachable when introduced in [11542] (2010): the handler filtered the selection to out-of-date plugins and breaked (not exit) when all were current, falling through to the notice. The iframe rewrite in [11232] removed that filtering and the break, leaving the notice behind. It has been dead code ever since.

Testing

• On the Plugins screen, no user action produces the notice; bulk Update always renders the iframe screen.
• php -l passes; no functional change (removed code was never reached).

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aminurislam01.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.