Create About Page for 7.1 - #12845
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
rbcorrales
left a comment
There was a problem hiding this comment.
Tested locally at different breakpoints plus an he_IL RTL pass. All five pages render clean, no PHP notices, and the RTL headers resolve correctly.
Comments are mostly copy. The one worth catching before RC1 is the run-on on 141, since it's user visible. The rest is minor.
| list( $display_version ) = explode( '-', get_bloginfo( 'version' ) ); | ||
| $header_alt_text = sprintf( | ||
| /* translators: %s: Version number. */ | ||
| __( 'WordPress %s' ), | ||
| $display_version | ||
| ); |
There was a problem hiding this comment.
Removing the header image leaves $header_alt_text unused, and $display_version only feeds it, so both are dead now. Same in credits.php, freedoms.php and privacy.php.
There was a problem hiding this comment.
I'm going to leave it for now; but thanks for noting it. If these images stay removed, I'll polish this and remove the dead code paths.
|
No, there's no need for a separate ticket; this ticket covers the entire scope of building out the About Page, because it's a one-off task for the release. |
|
@marko-srb Can you take a look at the color contrast concerns on mobile? We could use something like a text shadow on mobile only that addressed this, e.g. ( |
|
👋 Your suggestion works well. Let's go with minimal shadows. Not a good practice in general, but great fix suggestion for now. We will fix the images themselves so no contrast issues are present, prior 7.1 release. And swap them. Do we still need svg images for RTL? I thought we are going with webp? If we need them, I can deliver them in 1hr About page, text update is ok to happen, even if not applicable by someone on Google file. It's easy for us to change there, as long as it is good on the actual page. Though I'd leave this to Anne. But if this needs to ship, I can review, or provide text in an hr. Thank you! |
Co-authored-by: Ramon Corrales <rbcorrales@users.noreply.github.com>
Co-authored-by: Ramon Corrales <rbcorrales@users.noreply.github.com>
| </div> | ||
| <h3><?php _e( 'Accessibility' ); ?></h3> | ||
| <p><?php _e( 'WordPress continues to polish accessibility across WordPress Core and Gutenberg, advancing the goals to meet accessibility standards. WordPress 7.0 includes fixes across the platform, improving media management, usability for voice control, and improvements to color contrast with the new admin color scheme. The editor ships with new blocks and improvements to editor navigation and interaction.' ); ?></p> | ||
| <p><?php _e( 'WordPress 7.1 adds a "mark as decorative" toggle for the Image block, so decorative images can be hidden from screen readers, and the new admin bar and media editor modal have been built and reviewed with accessibility in mind. Work also continues on the post list tables and media library, as identified priorities in previous releases.' ); ?></p> |
There was a problem hiding this comment.
Split the sentence into 2.
WordPress 7.1 adds a "mark as decorative" toggle for the Image block, so decorative images can be hidden from screen readers. Additionally, the new admin bar and media editor modal have been built and reviewed with accessibility in mind.
| <strong><?php _e( 'Scrub through every version of your page.' ); ?></strong><br /> | ||
| <?php _e( 'Review your post’s revision history with a timeline slider and see exactly what changed in the document with visual markers, block by block. Find the version you want and restore it in one click.' ); ?> | ||
| <strong><?php _e( 'One dedicated workflow for editing your images.' ); ?></strong><br /> | ||
| <?php _e( 'A new media editor modal replaces the old inline cropping tool, bringing freeform and aspect-ratio cropping, flip, precise rotation, and metadata editing together in a single streamlined workflow. The familiar Crop button still gets you there, now opening a dedicated space to crop, rotate, and adjust images before publishing.' ); ?> |
There was a problem hiding this comment.
| <?php _e( 'A new media editor modal replaces the old inline cropping tool, bringing freeform and aspect-ratio cropping, flip, precise rotation, and metadata editing together in a single streamlined workflow. The familiar Crop button still gets you there, now opening a dedicated space to crop, rotate, and adjust images before publishing.' ); ?> | |
| <?php _e( 'A new media editor modal replaces the old inline cropping tool, bringing freeform and aspect-ratio cropping, flipping, precise rotation, and metadata editing together in a single streamlined workflow. The familiar Crop button still gets you there, now opening a dedicated space to crop, rotate, and adjust images before publishing.' ); ?> |
There was a problem hiding this comment.
Do we need to flip this image as well?
| <div class="about__section has-3-columns"> | ||
| <div class="column about__image is-vertically-aligned-top is-left-padding-zero"> | ||
| <img src="<?php echo esc_url( admin_url( 'images/about-release-badge.svg?ver=7.0' ) ); ?>" alt="" height="280" width="280" /> | ||
| <img src="<?php echo esc_url( admin_url( 'images/about-release-badge.svg?ver=7.1' ) ); ?>" alt="" height="280" width="280" /> |
There was a problem hiding this comment.
The alt attribute has always been empty. Should we include the version number in the alt?
| <div class="column is-vertically-aligned-center is-right-padding-zero"> | ||
| <div class="about__image"> | ||
| <img src="https://s.w.org/images/core/7.0/about-feature-01.webp" alt="" height="436" width="436" /> | ||
| <img src="./images/about-feature-01.webp" alt="" height="436" width="436" /> |
There was a problem hiding this comment.
| <img src="./images/about-feature-01.webp" alt="" height="436" width="436" /> | |
| <img src="./images/about-feature-01.webp" alt="" height="900" width="900" /> |
The values for the height and width attributes seem a bit outdated. There are no issues as the aspect ratio matches, but according to HTML specifications, it seems that the actual image size should be described. The same applies to other img tags.
https://html.spec.whatwg.org/multipage/embedded-content-other.html#dimension-attributes


Initial draft of the About Page for WordPress 7.1
This draft adds the feature images locally, as the CDN copies are not yet available.
Trac ticket: https://core.trac.wordpress.org/ticket/65698
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.